[GH-ISSUE #858] Different service check dialogs in agent vs automation manager #540

Closed
opened 2026-03-02 02:17:08 +03:00 by kerem · 4 comments
Owner

Originally created by @silversword411 on GitHub (Dec 12, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/858

Automation manager has:

2021-12-12_132810 - check service1

Agent check only has:

2021-12-12_132810 - check service2

Originally created by @silversword411 on GitHub (Dec 12, 2021). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/858 Automation manager has: ![2021-12-12_132810 - check service1](https://user-images.githubusercontent.com/13395348/145724804-9f53520a-a9b2-4337-9fc4-e626c6753252.png) Agent check only has: ![2021-12-12_132810 - check service2](https://user-images.githubusercontent.com/13395348/145724819-b34894ce-309a-4470-99fe-ef8c40aa5610.png)
kerem 2026-03-02 02:17:08 +03:00
Author
Owner

@dinger1986 commented on GitHub (Dec 12, 2021):

Is that not ok though? It will show all the services it detects on that one machine (that it has access to)

<!-- gh-comment-id:991948446 --> @dinger1986 commented on GitHub (Dec 12, 2021): Is that not ok though? It will show all the services it detects on that one machine (that it has access to)
Author
Owner

@silversword411 commented on GitHub (Dec 12, 2021):

I wouldn't expect the dialogs to be different capabilities, should be consistent. If there's a reason they can close issue :)

<!-- gh-comment-id:991949242 --> @silversword411 commented on GitHub (Dec 12, 2021): I wouldn't expect the dialogs to be different capabilities, should be consistent. If there's a reason they can close issue :)
Author
Owner

@dinger1986 commented on GitHub (Dec 12, 2021):

I think it's worse being able to type it in on an agent. But yes happy leaving it up to the devs

<!-- gh-comment-id:991951693 --> @dinger1986 commented on GitHub (Dec 12, 2021): I think it's worse being able to type it in on an agent. But yes happy leaving it up to the devs
Author
Owner

@wh1te909 commented on GitHub (Dec 13, 2021):

yes this is intentional, agent service checks don't need an option to choose or enter manually because we already know what services are available on that agent. When creating a policy check, we don't know what agents it will apply to, so we have no way of knowing what services are available. Which is why the user needs to enter manually or choose from a list of defaults which is just some array we hardcoded with popular services.

<!-- gh-comment-id:993006189 --> @wh1te909 commented on GitHub (Dec 13, 2021): yes this is intentional, agent service checks don't need an option to choose or enter manually because we already know what services are available on that agent. When creating a policy check, we don't know what agents it will apply to, so we have no way of knowing what services are available. Which is why the user needs to enter manually or choose from a list of defaults which is just some array we hardcoded with popular services.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#540
No description provided.