mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 06:55:52 +03:00
[GH-ISSUE #818] [Feature Request] Use single domain for frontend #514
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#514
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NiceGuyIT on GitHub (Nov 22, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/818
Is your feature request related to a problem? Please describe.
A common problem on Discord stems from the the frontend using the API domain and trying to proxy the API domain. This results in CORS errors, NATS issues among other problems.
Describe the solution you'd like
Use a single domain for the frontend,
rmm.example.com, and proxy all API calls to the appropriate backend in nginx.Describe alternatives you've considered
I have done this for my install.
Additional context
This issue is to gather feedback before working on the PR. I can submit the PR if approved.
This will solve the following issues.
This will allow the following.
The following changes are proposed.
nginxconfig to route the API calls to the Django uWSGI service.nginxconfig to route the websocket to the Django channels daemon.web/.envto thermm.example.comdomain for the frontend.install.shandupgrade.shscripts accordingly.Breaking changes.
Notes.
/api/), there will be a little extra maintenance burden going forward keeping the nginx config synced with the API calls/paths. I don't know if this can be scripted.Thoughts? Did I miss anything?
@wh1te909 commented on GitHub (Nov 23, 2021):
Very early versions of trmm actually were setup this way with a single domain and just proxying everything through nginx. I decided to separate them though to allow more flexibility for deployment, like with separate subdomains you can deploy your frontend to a different server or preferably a CDN since it's just a few static files. I'll let the community discuss this one we can see what people prefer and the pros and cons of each.
@NiceGuyIT commented on GitHub (Dec 1, 2021):
Moving this to a discussion about configuration organization and improvements. I believe with enough configuration options available, a single domain frontend can be optionally configured.