URLs #3883

New issue

Open

opened 2026-03-14 07:43:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 07:43:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/2381
Author: @Deenyoro
Created: 12/16/2025
Status: 🔄 Open

Base: develop ← Head: fix/mesh-wss-to-https-conversion

📝 Commits (2)

5a1b16f fix mesh agent downloads failing with wss:// URLs
2711dbf Merge branch 'develop' into fix/mesh-wss-to-https-conversion

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 api/tacticalrmm/core/utils.py (+1 -1)

📄 Description

The code was only converting ws:// to http:// but not handling wss:// to https://. When using secure websockets, this left the URL as wss:// which broke downloads since requests.get() can't handle websocket URLs.

Added .replace("wss://", "https://") to handle secure websockets.

Fixes the InvalidSchema exception when downloading mesh agents with secure websocket configs.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/2381 **Author:** [@Deenyoro](https://github.com/Deenyoro) **Created:** 12/16/2025 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `fix/mesh-wss-to-https-conversion` --- ### 📝 Commits (2) - [`5a1b16f`](https://github.com/amidaware/tacticalrmm/commit/5a1b16f4d5fdb00b0dbbec6618595c4e57121271) fix mesh agent downloads failing with wss:// URLs - [`2711dbf`](https://github.com/amidaware/tacticalrmm/commit/2711dbfce7e73e1f356137f60ea2c9017db2b77c) Merge branch 'develop' into fix/mesh-wss-to-https-conversion ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/tacticalrmm/core/utils.py` (+1 -1) </details> ### 📄 Description The code was only converting ws:// to http:// but not handling wss:// to https://. When using secure websockets, this left the URL as wss:// which broke downloads since requests.get() can't handle websocket URLs. Added .replace("wss://", "https://") to handle secure websockets. Fixes the InvalidSchema exception when downloading mesh agents with secure websocket configs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>