[PR #2359] [MERGED] Allow override of cookie domains via Docker environment #3879

New issue

Closed

opened 2026-03-14 07:43:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 07:43:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/2359
Author: @Thalagyrt
Created: 11/25/2025
Status: ✅ Merged
Merged: 12/1/2025
Merged by: @wh1te909

Base: develop ← Head: patch-docker-entrypoint-cookie-domain

📝 Commits (1)

5d1ef67 Allow override of cookie domains via Docker environment

📊 Changes

3 files changed (+11 additions, -2 deletions)

View changed files

📝 docker/.env.example (+4 -0)
📝 docker/containers/tactical/entrypoint.sh (+5 -2)
📝 docker/docker-compose.yml (+2 -0)

📄 Description

The docker entrypoint.sh sets BASE_DOMAIN based on the configured domains, but doesn't always get it quite right in every configuration.

This patch sets those variables in the entrypoint only if they are not already set, allowing an administrator finer control over them.

Josh and I had a discussion in the development Discord channel about this today. Specifically, my configuration isn't using a wildcard cert, but instead a cert with three CNs on it for mgmt.example.com, api.mgmt.example.com, and mesh.mgmt.example.com. The default in the Docker entrypoint is causing the app to set the cookie on example.com instead of mgmt.example.com, causing conflicts with other Django applications on other subdomains.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/2359 **Author:** [@Thalagyrt](https://github.com/Thalagyrt) **Created:** 11/25/2025 **Status:** ✅ Merged **Merged:** 12/1/2025 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `patch-docker-entrypoint-cookie-domain` --- ### 📝 Commits (1) - [`5d1ef67`](https://github.com/amidaware/tacticalrmm/commit/5d1ef6768fad2932af75a4998a8c928d4e1b4e31) Allow override of cookie domains via Docker environment ### 📊 Changes **3 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `docker/.env.example` (+4 -0) 📝 `docker/containers/tactical/entrypoint.sh` (+5 -2) 📝 `docker/docker-compose.yml` (+2 -0) </details> ### 📄 Description The docker entrypoint.sh sets BASE_DOMAIN based on the configured domains, but doesn't always get it quite right in every configuration. This patch sets those variables in the entrypoint only if they are not already set, allowing an administrator finer control over them. Josh and I had a discussion in the development Discord channel about this today. Specifically, my configuration isn't using a wildcard cert, but instead a cert with three CNs on it for `mgmt.example.com`, `api.mgmt.example.com`, and `mesh.mgmt.example.com`. The default in the Docker entrypoint is causing the app to set the cookie on `example.com` instead of `mgmt.example.com`, causing conflicts with other Django applications on other subdomains. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>