[PR #2046] Make update.sh work with RHEL-based distros #3847

Open
opened 2026-03-14 07:42:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/2046
Author: @egg82
Created: 10/25/2024
Status: 🔄 Open

Base: developHead: add-rhel


📝 Commits (5)

  • d6ba1d3 Make update.sh work with RHEL-based distros
  • 1b40277 rpm, not deb
  • 49779e0 Fix permissions for dirs above /rmm/api/tacticalrmm/tacticalrmm.sock
  • 3788693 No need to have Python env for every service
  • ad4ef7b Make update match install - pango

📊 Changes

1 file changed (+220 additions, -73 deletions)

View changed files

📝 update.sh (+220 -73)

📄 Description

The following changes are made:

  • Uses /etc/os-release to determine OS type
  • Uses command -v dnf to determine if dnf is available, and falls back to yum if not
  • Uses yum/dnf in place of apt and apt-get where applicable
  • Trades apt keyrings for yum GPG keys where applicable
  • Changes www-data for nginx user/group where applicable
  • Installs pango and pango-devel from proper sources when in a RHEL environment
  • Uses pyenv to install proper python version when in RHEL environment
  • Uses proper nodejs setup script and dnf/yum install when in a RHEL environment
  • Changes python manage.py to python3.11 manage.py to be consistent
  • Changes /etc/nginx/sites-available to /etc/nginx/conf.d when in a RHEL environment
  • Fixes the directory permissions of all of the parent directories for /rmm/api/tacticalrmm/tacticalrmm.sock (nginx can't access socket)

The biggest change is the use of pyenv which required editing the service files, but it works well. This change could easily be added to the Debian section if desired, which would be less work than manually compiling the version each time.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/2046 **Author:** [@egg82](https://github.com/egg82) **Created:** 10/25/2024 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `add-rhel` --- ### 📝 Commits (5) - [`d6ba1d3`](https://github.com/amidaware/tacticalrmm/commit/d6ba1d368696687c96623aa397eed3050b63404e) Make update.sh work with RHEL-based distros - [`1b40277`](https://github.com/amidaware/tacticalrmm/commit/1b40277802b7b5068d37558a8a5432afc92485d9) rpm, not deb - [`49779e0`](https://github.com/amidaware/tacticalrmm/commit/49779e06b3b297bf145f2e79bb9e0a1d50d0f12d) Fix permissions for dirs above /rmm/api/tacticalrmm/tacticalrmm.sock - [`3788693`](https://github.com/amidaware/tacticalrmm/commit/37886939c04836cbea574ed225b2ba63148f5c7e) No need to have Python env for every service - [`ad4ef7b`](https://github.com/amidaware/tacticalrmm/commit/ad4ef7b56efbf1da4d250d47c3ec269b70030b5b) Make update match install - pango ### 📊 Changes **1 file changed** (+220 additions, -73 deletions) <details> <summary>View changed files</summary> 📝 `update.sh` (+220 -73) </details> ### 📄 Description The following changes are made: * Uses `/etc/os-release` to determine OS type * Uses `command -v dnf` to determine if `dnf` is available, and falls back to `yum` if not * Uses `yum`/`dnf` in place of `apt` and `apt-get` where applicable * Trades apt keyrings for yum GPG keys where applicable * Changes `www-data` for `nginx` user/group where applicable * Installs `pango` and `pango-devel` from proper sources when in a RHEL environment * Uses `pyenv` to install proper python version when in RHEL environment * Uses proper nodejs setup script and `dnf`/`yum` install when in a RHEL environment * Changes `python manage.py` to `python3.11 manage.py` to be consistent * Changes `/etc/nginx/sites-available` to `/etc/nginx/conf.d` when in a RHEL environment * Fixes the directory permissions of all of the parent directories for `/rmm/api/tacticalrmm/tacticalrmm.sock` (nginx can't access socket) The biggest change is the use of `pyenv` which required editing the service files, but it works well. This change could easily be added to the Debian section if desired, which would be less work than manually compiling the version each time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#3847
No description provided.