mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 15:05:57 +03:00
[PR #1467] [MERGED] Enable hostname filtering for bulk agents deletion #3811
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#3811
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/amidaware/tacticalrmm/pull/1467
Author: @Supermanu
Created: 3/30/2023
Status: ✅ Merged
Merged: 4/7/2023
Merged by: @wh1te909
Base:
develop← Head:bulk_delete_agents_hostname📝 Commits (2)
59dcdd5Enable hostname filtering for bulk delete agents376f636Enable combination of filters for bulk agents deletion📊 Changes
1 file changed (+21 additions, -11 deletions)
View changed files
📝
api/tacticalrmm/agents/management/commands/bulk_delete_agents.py(+21 -11)📄 Description
Hey,
From time to time we need to replace a batch of computers and we need to remove the old agents in tacticalrmm. As they all start with the same hostname, this commit enables filtering them for deletion by hostname.
On a side note, it would be nice (for me) to use multiple filter at once, days and hostname for instance. I see that there are some optimizations going on and didn't suggest code changes. What I could submit, is to use a
.filter()on theQuerySetfor all the arguments except for theagentverwhich would remain unchanged. If this make sense, let me know and I will submit another PR.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.