[PR #1109] [CLOSED] Changes to Docker files and mesh entrypoint.sh #3775

New issue

Closed

opened 2026-03-14 07:38:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 07:38:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/1109
Author: @ninjamonkey198206
Created: 5/1/2022
Status: ❌ Closed

Base: develop ← Head: develop

📝 Commits (10+)

701d226 Update entrypoint.sh
59398f9 Update docker-compose.yml
4d63b60 Update .env.example
d66301e Merge branch 'amidaware:develop' into develop
242e572 Update create_natsapi_conf.py
2285db1 Update settings.py
a5a28c3 Update settings.py
196a31e Update create_natsapi_conf.py
d6d230c Merge branch 'amidaware:develop' into develop
e2979ab Merge branch 'amidaware:develop' into develop

📊 Changes

3 files changed (+135 additions, -42 deletions)

View changed files

📝 docker/.env.example (+78 -11)
📝 docker/containers/tactical-meshcentral/entrypoint.sh (+6 -4)
📝 docker/docker-compose.yml (+51 -27)

📄 Description

Update docker-compose.yml

Added variables x_GATEWAY and x_SUBNET to specify gateways and subnets to prevent occasional issues with gateways not properly initializing.
Added variable PROXY_IP for nginx proxy IP address that both sets the IP and informs mesh container of address per NGINX_HOST_IP entrypoint.sh variable.
Added container prefix variable CONTAINER_PREFIX to allow for easy deployment of multiple instances side by side by preventing same container names.
Added PROXY_HTTP_PORT and PROXY_HTTPS_PORT variables to set exposed proxy ports.
Added OS level network name variables PROXY_NET_NAME and API_DB_NET_NAME for proxy and api to alleviate issues when dealing with IPTables firewalls. Network names will stay consistent through reboots and other changes unless specifically edited. No br-blahblahblah to keep track of.
Added variable NATS_PORT to allow exposed nats port other than 4222. May need to update nats entrypoint.sh to be useful.
Filled out all network configs.

Update .env.example

Updated to include variables added to docker-compose file.

Update entrypoint.sh

Add Agent Alias and Alias port variables to allow env variable alteration.
Changed agent alias and alias port conf to use variables rather than hardcoded ports.
Changed SMTP user variable default definition to example@example.com, because it was what was listed in the later command, and I'm anal-retentive.
Changed mesh account creation command to use the smtp user variable instead of being hardcoded to example@example.com.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/1109 **Author:** [@ninjamonkey198206](https://github.com/ninjamonkey198206) **Created:** 5/1/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`701d226`](https://github.com/amidaware/tacticalrmm/commit/701d226cabc910b11c37b2bb49fbc5817a8dac94) Update entrypoint.sh - [`59398f9`](https://github.com/amidaware/tacticalrmm/commit/59398f96d8ca8e6590782ecd7d9073a49bd1c3ea) Update docker-compose.yml - [`4d63b60`](https://github.com/amidaware/tacticalrmm/commit/4d63b608f0d6d78218ce98628c6046a3c8587ae0) Update .env.example - [`d66301e`](https://github.com/amidaware/tacticalrmm/commit/d66301ea12ff384af8213499df0fa553fe13ae7c) Merge branch 'amidaware:develop' into develop - [`242e572`](https://github.com/amidaware/tacticalrmm/commit/242e57283c49d1477e455fb0cee14ec14c3e317a) Update create_natsapi_conf.py - [`2285db1`](https://github.com/amidaware/tacticalrmm/commit/2285db1a06afadb24f352880184d85bf0def2368) Update settings.py - [`a5a28c3`](https://github.com/amidaware/tacticalrmm/commit/a5a28c399cd99a2d9d1c5c4dc1aea96d6fc45629) Update settings.py - [`196a31e`](https://github.com/amidaware/tacticalrmm/commit/196a31ead28e3ef32e0eb2b672ff81f0c8912601) Update create_natsapi_conf.py - [`d6d230c`](https://github.com/amidaware/tacticalrmm/commit/d6d230c8c3a90bc1604a5064f2f329d47e839ed1) Merge branch 'amidaware:develop' into develop - [`e2979ab`](https://github.com/amidaware/tacticalrmm/commit/e2979ab83affeb807393d46aaf60c4ef6da8c321) Merge branch 'amidaware:develop' into develop ### 📊 Changes **3 files changed** (+135 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `docker/.env.example` (+78 -11) 📝 `docker/containers/tactical-meshcentral/entrypoint.sh` (+6 -4) 📝 `docker/docker-compose.yml` (+51 -27) </details> ### 📄 Description ### Update docker-compose.yml 1) Added variables x_GATEWAY and x_SUBNET to specify gateways and subnets to prevent occasional issues with gateways not properly initializing. 2) Added variable PROXY_IP for nginx proxy IP address that both sets the IP and informs mesh container of address per NGINX_HOST_IP entrypoint.sh variable. 3) Added container prefix variable CONTAINER_PREFIX to allow for easy deployment of multiple instances side by side by preventing same container names. 4) Added PROXY_HTTP_PORT and PROXY_HTTPS_PORT variables to set exposed proxy ports. 5) Added OS level network name variables PROXY_NET_NAME and API_DB_NET_NAME for proxy and api to alleviate issues when dealing with IPTables firewalls. Network names will stay consistent through reboots and other changes unless specifically edited. No br-blahblahblah to keep track of. 6) Added variable NATS_PORT to allow exposed nats port other than 4222. May need to update nats entrypoint.sh to be useful. 7) Filled out all network configs. ### Update .env.example 1) Updated to include variables added to docker-compose file. ### Update entrypoint.sh 1) Add Agent Alias and Alias port variables to allow env variable alteration. 2) Changed agent alias and alias port conf to use variables rather than hardcoded ports. 3) Changed SMTP user variable default definition to example@example.com, because it was what was listed in the later command, and I'm anal-retentive. 4) Changed mesh account creation command to use the smtp user variable instead of being hardcoded to example@example.com. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>