[PR #1008] [MERGED] Global datetime format and other GH issue fixes

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/1008 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 3/19/2022 **Status:** ✅ Merged **Merged:** 4/11/2022 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`6fefd55`](https://github.com/amidaware/tacticalrmm/commit/6fefd5589c3306d1d0271db2a4d72cd1ba23081c) Allow canceling other pending actions. Fixes #958 - [`903f0e5`](https://github.com/amidaware/tacticalrmm/commit/903f0e5e1956a11d472574212978c478d834ca88) implement global datetime format. #1007 - [`c152e18`](https://github.com/amidaware/tacticalrmm/commit/c152e18e1a9b2dc8149a4b5bc4ad67e8ed479cba) policy rework init - [`b5ae875`](https://github.com/amidaware/tacticalrmm/commit/b5ae875589274fbbb3549fa879cd484f34cf12c1) fix issue with multiple alert object being returned - [`0623f53`](https://github.com/amidaware/tacticalrmm/commit/0623f53f5df7804cb412ddfee13b3be14adfaf65) fix date format string empty - [`826ac7f`](https://github.com/amidaware/tacticalrmm/commit/826ac7f185d5f829547a115733ec1bcd53c26ff7) returned tasks/checks in agent runner serializer and saving results - [`b0ac570`](https://github.com/amidaware/tacticalrmm/commit/b0ac57040c4f6eab44027a902477e51aade54b4b) cleanup migrations and rework all checks/tasks to use the task/results table. fix alerts - [`69ef767`](https://github.com/amidaware/tacticalrmm/commit/69ef7676afcccfe03b64d6d999e167f1bcf6e620) finalize the schema and fix ui for checks - [`6ffdf5c`](https://github.com/amidaware/tacticalrmm/commit/6ffdf5c25144befd9fa59de6fc245d116ee7bb7f) Fixed Check History graph and reworked task sync_status - [`e38af9f`](https://github.com/amidaware/tacticalrmm/commit/e38af9fd163a12022340ecb2b67c7307847b16c7) rework task create/modify/delete/running and fix checks tests ### 📊 Changes **137 files changed** (+4658 additions, -3833 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/docker-compose.yml` (+3 -2) 📝 `.devcontainer/entrypoint.sh` (+3 -0) 📝 `.devcontainer/requirements.txt` (+21 -16) 📝 `.vscode/settings.json` (+19 -1) ➖ `.vscode/tasks.json` (+0 -23) ➕ `api/tacticalrmm/accounts/migrations/0031_user_date_format.py` (+18 -0) 📝 `api/tacticalrmm/accounts/models.py` (+29 -0) 📝 `api/tacticalrmm/accounts/permissions.py` (+3 -3) 📝 `api/tacticalrmm/accounts/serializers.py` (+2 -0) 📝 `api/tacticalrmm/accounts/tests.py` (+8 -8) 📝 `api/tacticalrmm/agents/management/commands/fake_agents.py` (+112 -60) 📝 `api/tacticalrmm/agents/management/commands/update_agents.py` (+3 -3) ➕ `api/tacticalrmm/agents/migrations/0047_alter_agent_plat_alter_agent_site.py` (+26 -0) 📝 `api/tacticalrmm/agents/models.py` (+234 -140) 📝 `api/tacticalrmm/agents/permissions.py` (+14 -14) 📝 `api/tacticalrmm/agents/serializers.py` (+1 -14) 📝 `api/tacticalrmm/agents/tasks.py` (+42 -27) 📝 `api/tacticalrmm/agents/tests.py` (+121 -100) 📝 `api/tacticalrmm/agents/utils.py` (+20 -16) 📝 `api/tacticalrmm/agents/views.py` (+40 -26) _...and 80 more files_ </details> ### 📄 Description ### DateTime format - [x] Global datetime format - [x] Add date string format helper - [x] Set default when coresettings is blank - [x] Add datetime format user preference (overrides global) ### Policy Rework - [x] Policy rework DB changes - [x] Populate policy checks/tasks in agent tabs - [x] Update task/check runner serializers to return policy check/tasks - [x] Associate the alert correctly with policy checks/tasks - [x] Create policy tasks during cache task - [x] Save policy check/task results when agent runs them - [x] filter the alerts correctly in the UI (policy checks/tasks with alerts aren't showing) - [x] Update Automation manager policy/check status - [x] Cleanup tests - [x] Fix tests - [x] Create migration for task/check result data ### Other Fixes - [x] Deleting other pending action types --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem commented

2026-03-14 07:37:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/1008
Author: @sadnub
Created: 3/19/2022
Status: ✅ Merged
Merged: 4/11/2022
Merged by: @wh1te909

Base: develop ← Head: develop

📝 Commits (10+)

6fefd55 Allow canceling other pending actions. Fixes #958
903f0e5 implement global datetime format. #1007
c152e18 policy rework init
b5ae875 fix issue with multiple alert object being returned
0623f53 fix date format string empty
826ac7f returned tasks/checks in agent runner serializer and saving results
b0ac570 cleanup migrations and rework all checks/tasks to use the task/results table. fix alerts
69ef767 finalize the schema and fix ui for checks
6ffdf5c Fixed Check History graph and reworked task sync_status
e38af9f rework task create/modify/delete/running and fix checks tests

📊 Changes

137 files changed (+4658 additions, -3833 deletions)

View changed files

📝 .devcontainer/docker-compose.yml (+3 -2)
📝 .devcontainer/entrypoint.sh (+3 -0)
📝 .devcontainer/requirements.txt (+21 -16)
📝 .vscode/settings.json (+19 -1)
➖ .vscode/tasks.json (+0 -23)
➕ api/tacticalrmm/accounts/migrations/0031_user_date_format.py (+18 -0)
📝 api/tacticalrmm/accounts/models.py (+29 -0)
📝 api/tacticalrmm/accounts/permissions.py (+3 -3)
📝 api/tacticalrmm/accounts/serializers.py (+2 -0)
📝 api/tacticalrmm/accounts/tests.py (+8 -8)
📝 api/tacticalrmm/agents/management/commands/fake_agents.py (+112 -60)
📝 api/tacticalrmm/agents/management/commands/update_agents.py (+3 -3)
➕ api/tacticalrmm/agents/migrations/0047_alter_agent_plat_alter_agent_site.py (+26 -0)
📝 api/tacticalrmm/agents/models.py (+234 -140)
📝 api/tacticalrmm/agents/permissions.py (+14 -14)
📝 api/tacticalrmm/agents/serializers.py (+1 -14)
📝 api/tacticalrmm/agents/tasks.py (+42 -27)
📝 api/tacticalrmm/agents/tests.py (+121 -100)
📝 api/tacticalrmm/agents/utils.py (+20 -16)
📝 api/tacticalrmm/agents/views.py (+40 -26)

...and 80 more files

📄 Description

DateTime format

Global datetime format
Add date string format helper
Set default when coresettings is blank
Add datetime format user preference (overrides global)

Policy Rework

Policy rework DB changes
Populate policy checks/tasks in agent tabs
Update task/check runner serializers to return policy check/tasks
Associate the alert correctly with policy checks/tasks
Create policy tasks during cache task
Save policy check/task results when agent runs them
filter the alerts correctly in the UI (policy checks/tasks with alerts aren't showing)
Update Automation manager policy/check status
Cleanup tests
Fix tests
Create migration for task/check result data

Other Fixes

Deleting other pending action types

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem

closed this issue
added the
pull-request
label

Rows
Columns

[PR #1008] [MERGED] Global datetime format and other GH issue fixes #3763