[PR #118] [MERGED] Some tweaks and tests #3483

New issue

Closed

opened 2026-03-14 07:22:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 07:22:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/118
Author: @sadnub
Created: 9/25/2020
Status: ✅ Merged
Merged: 9/26/2020
Merged by: @wh1te909

Base: develop ← Head: develop

📝 Commits (5)

425f168 tweak to totp setup to not logout user if totp is already set and redirect to dashboard
3e01dcf change casing on totp setup response
e79c616 logs tests
2f23081 move logs and accounts tests to new Tactical base test
54eab21 bump ver

📊 Changes

7 files changed (+172 additions, -27 deletions)

View changed files

📝 api/tacticalrmm/accounts/tests.py (+29 -16)
📝 api/tacticalrmm/accounts/views.py (+1 -1)
📝 api/tacticalrmm/core/models.py (+1 -1)
📝 api/tacticalrmm/logs/tests.py (+104 -2)
📝 api/tacticalrmm/tacticalrmm/settings.py (+1 -1)
📝 api/tacticalrmm/tacticalrmm/test.py (+31 -1)
📝 web/src/views/TOTPSetup.vue (+5 -5)

📄 Description

Let me know if this works. I created a new base test class that we can add helper methods too. I did have to override some of the django settings for MESH_TOKEN, otherwise my tests hang for two minutes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/118 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 9/25/2020 **Status:** ✅ Merged **Merged:** 9/26/2020 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (5) - [`425f168`](https://github.com/amidaware/tacticalrmm/commit/425f168a6ca28338881a9bf772efc176182b498e) tweak to totp setup to not logout user if totp is already set and redirect to dashboard - [`3e01dcf`](https://github.com/amidaware/tacticalrmm/commit/3e01dcf3be50686d3cd498a305cb30166c5937f5) change casing on totp setup response - [`e79c616`](https://github.com/amidaware/tacticalrmm/commit/e79c61626a3c958ccf7f96cf8a207da0d47b04fa) logs tests - [`2f23081`](https://github.com/amidaware/tacticalrmm/commit/2f230815ad0c9ed7dc45f1d342bfe2f2b0399a0e) move logs and accounts tests to new Tactical base test - [`54eab21`](https://github.com/amidaware/tacticalrmm/commit/54eab21db84d7bc56551c28c945fe07cd729b0ad) bump ver ### 📊 Changes **7 files changed** (+172 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `api/tacticalrmm/accounts/tests.py` (+29 -16) 📝 `api/tacticalrmm/accounts/views.py` (+1 -1) 📝 `api/tacticalrmm/core/models.py` (+1 -1) 📝 `api/tacticalrmm/logs/tests.py` (+104 -2) 📝 `api/tacticalrmm/tacticalrmm/settings.py` (+1 -1) 📝 `api/tacticalrmm/tacticalrmm/test.py` (+31 -1) 📝 `web/src/views/TOTPSetup.vue` (+5 -5) </details> ### 📄 Description Let me know if this works. I created a new base test class that we can add helper methods too. I did have to override some of the django settings for MESH_TOKEN, otherwise my tests hang for two minutes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>