[PR #45] [MERGED] WIP Alerts functionality (Stopped Error messages). Fix for policy checks/tasks #3465

New issue

Closed

opened 2026-03-14 07:21:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 07:21:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/45
Author: @sadnub
Created: 8/15/2020
Status: ✅ Merged
Merged: 8/15/2020
Merged by: @wh1te909

Base: develop ← Head: feature-policies-alerts

📝 Commits (3)

4b366ad Added frontrend and backend for alerts to stop error messages. Still WIP. Fixed related_agents function to help with policy check bugs.
78a3992 More policy fixes. Should make policy changes to location work now
8ebcfd3 Fix tests

📊 Changes

22 files changed (+258 additions, -71 deletions)

View changed files

➕ api/tacticalrmm/alerts/__init__.py (+0 -0)
➕ api/tacticalrmm/alerts/admin.py (+3 -0)
➕ api/tacticalrmm/alerts/apps.py (+5 -0)
➕ api/tacticalrmm/alerts/migrations/0001_initial.py (+28 -0)
➕ api/tacticalrmm/alerts/migrations/0002_auto_20200815_1618.py (+22 -0)
➕ api/tacticalrmm/alerts/migrations/__init__.py (+0 -0)
➕ api/tacticalrmm/alerts/models.py (+27 -0)
➕ api/tacticalrmm/alerts/serializers.py (+17 -0)
➕ api/tacticalrmm/alerts/tests.py (+3 -0)
➕ api/tacticalrmm/alerts/urls.py (+7 -0)
➕ api/tacticalrmm/alerts/views.py (+44 -0)
📝 api/tacticalrmm/automation/models.py (+7 -7)
📝 api/tacticalrmm/automation/tasks.py (+0 -2)
📝 api/tacticalrmm/automation/tests.py (+4 -4)
📝 api/tacticalrmm/automation/views.py (+10 -12)
📝 api/tacticalrmm/tacticalrmm/settings.py (+1 -0)
📝 api/tacticalrmm/tacticalrmm/urls.py (+1 -0)
📝 docker/docker-compose.dev.yml (+1 -1)
📝 docker/readme.md (+1 -1)
📝 web/src/components/AlertsIcon.vue (+28 -28)

...and 2 more files

📄 Description

I haven't 100% tested the policy checks, but I found that I was using the site and client fields on the agents for my filter functions. I changed that to pk and that should help with the duplicate names issue. I will keep on testing!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/45 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 8/15/2020 **Status:** ✅ Merged **Merged:** 8/15/2020 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `feature-policies-alerts` --- ### 📝 Commits (3) - [`4b366ad`](https://github.com/amidaware/tacticalrmm/commit/4b366ad53a0c6b2f92af6354e8d8b8319a266aba) Added frontrend and backend for alerts to stop error messages. Still WIP. Fixed related_agents function to help with policy check bugs. - [`78a3992`](https://github.com/amidaware/tacticalrmm/commit/78a3992eb19f3444bb791a4f316912b6b4ca1a01) More policy fixes. Should make policy changes to location work now - [`8ebcfd3`](https://github.com/amidaware/tacticalrmm/commit/8ebcfd33222a500ff930ad66323d16903c73e67b) Fix tests ### 📊 Changes **22 files changed** (+258 additions, -71 deletions) <details> <summary>View changed files</summary> ➕ `api/tacticalrmm/alerts/__init__.py` (+0 -0) ➕ `api/tacticalrmm/alerts/admin.py` (+3 -0) ➕ `api/tacticalrmm/alerts/apps.py` (+5 -0) ➕ `api/tacticalrmm/alerts/migrations/0001_initial.py` (+28 -0) ➕ `api/tacticalrmm/alerts/migrations/0002_auto_20200815_1618.py` (+22 -0) ➕ `api/tacticalrmm/alerts/migrations/__init__.py` (+0 -0) ➕ `api/tacticalrmm/alerts/models.py` (+27 -0) ➕ `api/tacticalrmm/alerts/serializers.py` (+17 -0) ➕ `api/tacticalrmm/alerts/tests.py` (+3 -0) ➕ `api/tacticalrmm/alerts/urls.py` (+7 -0) ➕ `api/tacticalrmm/alerts/views.py` (+44 -0) 📝 `api/tacticalrmm/automation/models.py` (+7 -7) 📝 `api/tacticalrmm/automation/tasks.py` (+0 -2) 📝 `api/tacticalrmm/automation/tests.py` (+4 -4) 📝 `api/tacticalrmm/automation/views.py` (+10 -12) 📝 `api/tacticalrmm/tacticalrmm/settings.py` (+1 -0) 📝 `api/tacticalrmm/tacticalrmm/urls.py` (+1 -0) 📝 `docker/docker-compose.dev.yml` (+1 -1) 📝 `docker/readme.md` (+1 -1) 📝 `web/src/components/AlertsIcon.vue` (+28 -28) _...and 2 more files_ </details> ### 📄 Description I haven't 100% tested the policy checks, but I found that I was using the site and client fields on the agents for my filter functions. I changed that to pk and that should help with the duplicate names issue. I will keep on testing! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>