[GH-ISSUE #2062] Fix "Unknown Make/Model" #3227

Open
opened 2026-03-14 06:54:14 +03:00 by kerem · 1 comment
Owner

Originally created by @ZzBombardierzZ on GitHub (Nov 6, 2024).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/2062

Is your feature request related to a problem? Please describe.
It's frustrating when occasionally I view an agent or sync to Hudu, and it shows as "Unknown Make/Model".

Interestingly, my reports don't have this issue because I pull the data from wmi_details:

                                    <td>{{ item.wmi_detail.comp_sys[0][0].Manufacturer if item.wmi_detail and item.wmi_detail.comp_sys and item.wmi_detail.comp_sys[0] and item.wmi_detail.comp_sys[0][0] and item.wmi_detail.comp_sys[0][0].Manufacturer else 'N/A' }}</td>
                                    <td>
                                        {% if item.wmi_detail and item.wmi_detail.comp_sys and item.wmi_detail.comp_sys[0] and item.wmi_detail.comp_sys[0][0] and item.wmi_detail.comp_sys[0][0].Manufacturer == 'LENOVO' and item.wmi_detail.comp_sys_prod and item.wmi_detail.comp_sys_prod[0] and item.wmi_detail.comp_sys_prod[0][0] %}
                                            {{ item.wmi_detail.comp_sys_prod[0][0].Version if item.wmi_detail.comp_sys_prod[0][0].Version else 'N/A' }}
                                        {% elif item.wmi_detail and item.wmi_detail.comp_sys and item.wmi_detail.comp_sys[0] and item.wmi_detail.comp_sys[0][0] %}
                                            {{ item.wmi_detail.comp_sys[0][0].Model if item.wmi_detail.comp_sys[0][0].Model else 'N/A' }}
                                        {% else %}
                                            N/A
                                        {% endif %}
                                    </td>

Describe the solution you'd like
When syncing data from the agent, if the make/model is unavailable, do not update the existing (correct) make/model.

Describe alternatives you've considered

  • I could store a custom field for this and do it myself, but I'd prefer not to. =)

  • Get the make and model similarly to my report's code snippet above.

Additional context
Hudu example list:
image

TRMM Agent view:
image

Report of same agent:
image

Originally created by @ZzBombardierzZ on GitHub (Nov 6, 2024). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/2062 **Is your feature request related to a problem? Please describe.** It's frustrating when occasionally I view an agent or sync to Hudu, and it shows as "Unknown Make/Model". Interestingly, my reports don't have this issue because I pull the data from wmi_details: ``` <td>{{ item.wmi_detail.comp_sys[0][0].Manufacturer if item.wmi_detail and item.wmi_detail.comp_sys and item.wmi_detail.comp_sys[0] and item.wmi_detail.comp_sys[0][0] and item.wmi_detail.comp_sys[0][0].Manufacturer else 'N/A' }}</td> <td> {% if item.wmi_detail and item.wmi_detail.comp_sys and item.wmi_detail.comp_sys[0] and item.wmi_detail.comp_sys[0][0] and item.wmi_detail.comp_sys[0][0].Manufacturer == 'LENOVO' and item.wmi_detail.comp_sys_prod and item.wmi_detail.comp_sys_prod[0] and item.wmi_detail.comp_sys_prod[0][0] %} {{ item.wmi_detail.comp_sys_prod[0][0].Version if item.wmi_detail.comp_sys_prod[0][0].Version else 'N/A' }} {% elif item.wmi_detail and item.wmi_detail.comp_sys and item.wmi_detail.comp_sys[0] and item.wmi_detail.comp_sys[0][0] %} {{ item.wmi_detail.comp_sys[0][0].Model if item.wmi_detail.comp_sys[0][0].Model else 'N/A' }} {% else %} N/A {% endif %} </td> ``` **Describe the solution you'd like** When syncing data from the agent, if the make/model is unavailable, do not update the existing (correct) make/model. **Describe alternatives you've considered** * I could store a custom field for this and do it myself, but I'd prefer not to. =) * Get the make and model similarly to my report's code snippet above. **Additional context** Hudu example list: ![image](https://github.com/user-attachments/assets/c4d7b0b0-99bc-4160-b6d1-41f7818b469c) TRMM Agent view: ![image](https://github.com/user-attachments/assets/15e59a07-9c38-44c5-86b2-1b6cb930dec1) Report of same agent: ![image](https://github.com/user-attachments/assets/2cab7ec0-52c4-4d61-bdcd-0f7accc2b69c)
Author
Owner

@ZzBombardierzZ commented on GitHub (Feb 7, 2025):

@wh1te909 - Sorry to ping, but any chance this can be fixed in the next release? I imagine it's probably an easy enough problem to fix quickly.

<!-- gh-comment-id:2641405467 --> @ZzBombardierzZ commented on GitHub (Feb 7, 2025): @wh1te909 - Sorry to ping, but any chance this can be fixed in the next release? I imagine it's probably an easy enough problem to fix quickly.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#3227
No description provided.