[GH-ISSUE #1984] [UI issue] all the content of Global key store should not be visible at once #3189

Open
opened 2026-03-14 06:49:09 +03:00 by kerem · 2 comments
Owner

Originally created by @P6g9YHK6 on GitHub (Aug 19, 2024).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1984

Originally assigned to: @wh1te909 on GitHub.

Is your feature request related to a problem? Please describe.
Global key store is supposed to contain all the global passwords and api key to keep it far from the scripts and clients but currently simply going on the page display all the password in clear text !

Describe the solution you'd like
1 the key should not be displayed on the page only the name of the key should be visible
2 when clicking on them they should be obfuscated with ****** until a button is pressed to reveal it
3 a dedicated permission in the role manager to even interact with the function (i know there could be other ways to get them, but it is a step in the right direction)

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
image
image

Originally created by @P6g9YHK6 on GitHub (Aug 19, 2024). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1984 Originally assigned to: @wh1te909 on GitHub. **Is your feature request related to a problem? Please describe.** Global key store is supposed to contain all the global passwords and api key to keep it far from the scripts and clients but currently simply going on the page display all the password in _**clear text !**_ **Describe the solution you'd like** 1 the key should not be displayed on the page only the name of the key should be visible 2 when clicking on them they should be obfuscated with ****** until a button is pressed to reveal it 3 a dedicated permission in the role manager to even interact with the function (i know there could be other ways to get them, but it is a step in the right direction) **Describe alternatives you've considered** A clear and concise description of any alternative solutions or features you've considered. **Additional context** Add any other context or screenshots about the feature request here. ![image](https://github.com/user-attachments/assets/e08258c9-0f84-42b6-a01c-31144a873b3c) ![image](https://github.com/user-attachments/assets/4fe7181b-3d17-4b3f-83d2-a97dc49e148f)
Author
Owner

@wh1te909 commented on GitHub (Oct 6, 2024):

Added the visual stuff and also created a dedicated permission for viewing/editing keystore

https://github.com/user-attachments/assets/26e9c36e-f951-48e3-a1be-78287000db96

chrome_T9CBgn0V2W

<!-- gh-comment-id:2395306757 --> @wh1te909 commented on GitHub (Oct 6, 2024): Added the visual stuff and also created a dedicated permission for viewing/editing keystore https://github.com/user-attachments/assets/26e9c36e-f951-48e3-a1be-78287000db96 ![chrome_T9CBgn0V2W](https://github.com/user-attachments/assets/7ed76b0c-2e1a-4e42-99b7-a230f00cce99)
Author
Owner

@P6g9YHK6 commented on GitHub (Oct 7, 2024):

Added the visual stuff and also created a dedicated permission for viewing/editing keystore

chrome_tMtr8j9gfP.mp4
chrome_T9CBgn0V2W

possible to move the button there ? display all is overkill for any use
image

or even don't have it at all view from the field itself should be enough

<!-- gh-comment-id:2396997110 --> @P6g9YHK6 commented on GitHub (Oct 7, 2024): > Added the visual stuff and also created a dedicated permission for viewing/editing keystore > > chrome_tMtr8j9gfP.mp4 > ![chrome_T9CBgn0V2W](https://private-user-images.githubusercontent.com/7434746/373925334-7ed76b0c-2e1a-4e42-99b7-a230f00cce99.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjgzMDkyNzEsIm5iZiI6MTcyODMwODk3MSwicGF0aCI6Ii83NDM0NzQ2LzM3MzkyNTMzNC03ZWQ3NmIwYy0yZTFhLTRlNDItOTliNy1hMjMwZjAwY2NlOTkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MTAwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDEwMDdUMTM0OTMxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGNiOTFmYTBhZTAxYzBlOWYxZDJjOWE0Zjk3NTIwYmVkYjc1YThiODYyOTEyZDUyMDNhNGI4YmY1MTRmYzQ4YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.Z-JcFog-1JdF49qwHQqG4-CS51io6NJ5X8Xbx3a6C4Y) possible to move the button there ? display all is overkill for any use ![image](https://github.com/user-attachments/assets/3d28f472-95f0-4f3b-b4a3-7f8aa4b6bf29) or even don't have it at all view from the field itself should be enough
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#3189
No description provided.