[GH-ISSUE #1936] Duplicate Hostname in Email subject and body in Check/Task Failed messages #3152

New issue

Closed

opened 2026-03-14 06:43:29 +03:00 by kerem · 2 comments

kerem commented

2026-03-14 06:43:29 +03:00

Owner

Originally created by @nescafe2002 on GitHub (Jul 26, 2024).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1936

Server Info (please complete the following information):

RMM Version (as shown in top left of web UI): 0.19.2

Installation Method:

Docker

Agent Info (please complete the following information):

Agent version (as shown in the 'Summary' tab of the agent from web UI): 2.7.0

Describe the bug
Email subject and body contain hostname twice:
Client, Site, Hostname - Hostname - [Policy Name ] - [Check Name] Failed (- [More info])

Additional context
Note that the hostname is included in the (failed) templates and the __str__ methods.

For Checks:

github.com/amidaware/tacticalrmm@c8d72ddd3b/api/tacticalrmm/checks/models.py (L531)

github.com/amidaware/tacticalrmm@c8d72ddd3b/api/tacticalrmm/checks/models.py (L158)

For Tasks:

github.com/amidaware/tacticalrmm@c8d72ddd3b/api/tacticalrmm/autotasks/models.py (L525)

github.com/amidaware/tacticalrmm@c8d72ddd3b/api/tacticalrmm/autotasks/models.py (L541)

github.com/amidaware/tacticalrmm@c8d72ddd3b/api/tacticalrmm/autotasks/models.py (L497)

Possible solutions:

Remove hostname from __str__ functions and add hostname to send_resolved_email functions
Revert commits github.com/amidaware/tacticalrmm@6b9d775cb9 and github.com/amidaware/tacticalrmm@4cae9cd90d

Also, note that the subject (Client, Site) is not included in the body of the Check resolved message:

github.com/amidaware/tacticalrmm@c8d72ddd3b/api/tacticalrmm/checks/models.py (L656)

Originally created by @nescafe2002 on GitHub (Jul 26, 2024). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1936 **Server Info (please complete the following information):** - RMM Version (as shown in top left of web UI): 0.19.2 **Installation Method:** - [x] Docker **Agent Info (please complete the following information):** - Agent version (as shown in the 'Summary' tab of the agent from web UI): 2.7.0 **Describe the bug** Email subject and body contain hostname twice: Client, Site, Hostname - Hostname - [Policy Name ] - [Check Name] Failed (- [More info]) **Additional context** Note that the hostname is included in the (failed) templates and the `__str__` methods. For Checks: https://github.com/amidaware/tacticalrmm/blob/c8d72ddd3bf80cd2d8387f4e2c1911ff2ea806a0/api/tacticalrmm/checks/models.py#L531 https://github.com/amidaware/tacticalrmm/blob/c8d72ddd3bf80cd2d8387f4e2c1911ff2ea806a0/api/tacticalrmm/checks/models.py#L158 For Tasks: https://github.com/amidaware/tacticalrmm/blob/c8d72ddd3bf80cd2d8387f4e2c1911ff2ea806a0/api/tacticalrmm/autotasks/models.py#L525 https://github.com/amidaware/tacticalrmm/blob/c8d72ddd3bf80cd2d8387f4e2c1911ff2ea806a0/api/tacticalrmm/autotasks/models.py#L541 https://github.com/amidaware/tacticalrmm/blob/c8d72ddd3bf80cd2d8387f4e2c1911ff2ea806a0/api/tacticalrmm/autotasks/models.py#L497 Possible solutions: - Remove hostname from `__str__` functions and add hostname to `send_resolved_email` functions - Revert commits https://github.com/amidaware/tacticalrmm/commit/6b9d775cb99f654f29fb486aea9d189cc5167eff and https://github.com/amidaware/tacticalrmm/commit/4cae9cd90dc4b4ffa063282b75c05b1fb2e778ce Also, note that the subject (Client, Site) is not included in the body of the Check resolved message: https://github.com/amidaware/tacticalrmm/blob/c8d72ddd3bf80cd2d8387f4e2c1911ff2ea806a0/api/tacticalrmm/checks/models.py#L656

kerem closed this issue

2026-03-14 06:43:35 +03:00

kerem commented

2026-03-14 06:43:40 +03:00

Author

Owner

@SpookOz commented on GitHub (Jan 18, 2026):

Hi team, I might be mistaken, but since this was implemented, it seems like the hostname no longer appears in the subject in the "Resolved" emails...

@SpookOz commented on GitHub (Jan 18, 2026): Hi team, I might be mistaken, but since this was implemented, it seems like the hostname no longer appears in the subject in the "Resolved" emails...

kerem commented

2026-03-14 06:43:45 +03:00

Author

Owner

@SpookOz commented on GitHub (Jan 19, 2026):

Note, this has been addressed in https://github.com/amidaware/tacticalrmm/pull/2388

@SpookOz commented on GitHub (Jan 19, 2026): Note, this has been addressed in https://github.com/amidaware/tacticalrmm/pull/2388