mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 06:55:52 +03:00
[GH-ISSUE #1820] Allow Usernames With Spaces #3076
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#3076
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LPJon on GitHub (Mar 30, 2024).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1820
Is your feature request related to a problem? Please describe.
The latest update which syncs meshcentral does not support usernames that are not email addresses.
Describe the solution you'd like
Support for both email address usernames and non email address usernames. Such as "John Doe" and "Jon.Doe@corporate.com"
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
We do not always use email addresses as usernames because a compromised email address could be used to attempt access to the UI with guessing known email addresses.
@LPJon commented on GitHub (Mar 30, 2024):
It looks Like it just doesn't support spaces. Could support for just that be added?
@wh1te909 commented on GitHub (Mar 30, 2024):
just pushed a fix for this, please run the following 2 commands to test it out and then toggle the sync off/on from global settings > meshcentral in the web UI, and it should work:
@LPJon commented on GitHub (Apr 5, 2024):
@wh1te909 Sorry this took so long to get back to. The issue still exists as pictured below. I also reboot the TacticalRMM server just to be sure all necessary services restarted on top of your instructions above.
Just so I know I was clear. The username area I need is under Settings->User Administrator->->Username Field
The picture shows what I want to be able to do and it also shows the error I'm getting in the UI at the top.
@wh1te909 commented on GitHub (Apr 5, 2024):
Ah I see, yea usernames with spaces are not allowed, that the policy of the web framework we use (Django) you can see the code for that here. If Django doesn't allow it there must be a good reason and I trust them on that.
@LPJon commented on GitHub (Apr 6, 2024):
@wh1te909 Here is one that is strange for ya. Your install script uses
manage.pyto setup the first user on installation with line 568:python manage.py createsuperuser --username ${djangousername} --email ${letsemail}. When setting up the user here, you are allowed to use names with spaces just as requested above. That method works, so is there a command line option which I could change or setup a user name with?