starred/tacticalrmm
1
0
Fork 0
mirror of https://github.com/amidaware/tacticalrmm.git synced 2026-04-26 15:05:57 +03:00
Code Issues 919 Projects Releases 5 Packages Wiki Activity

[GH-ISSUE #1671] Regression of issue 1199 with uvicorn: Retrying websockets connection with an invalid token #2987

New issue
Open
opened 2026-03-14 06:09:55 +03:00 by kerem · 1 comment
kerem commented 2026-03-14 06:09:55 +03:00
Owner
Copy link

Originally created by @NiceGuyIT on GitHub (Nov 8, 2023).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1671

Server Info (please complete the following information):

  • OS: Ubuntu 20.04.4 LTS
  • Browser: Firefox 115.3.1esr
  • RMM Version (as shown in top left of web UI): v0.17.1

Installation Method:

  • Standard
  • Docker

Agent Info (please complete the following information):

  • Agent version (as shown in the 'Summary' tab of the agent from web UI): N/A
  • Agent OS: N/A

Describe the bug
This is a regression of #1199 with the uvicorn implementation. After upgrading the server, I kept getting the error below. The browser kept retrying the connection even though it received an error. Every retry caused an exception in the server logs. This will happen continuously as long as the browser is running. I.e. there is no way for the server to stop the client from retrying.

To Reproduce
Steps to reproduce the behavior:

  1. Log in to the RMM.
  2. Upgrade the server. I don't know if restarting will cause the same problem.
  3. After the server is upgraded, follow the logs. journalctl --follow
  4. See the error below.

Expected behavior
The client (browser) should not keep retrying if it receives an invalid status code from the server. In this case, it was 403 Forbidden

Screenshots
If applicable, add screenshots to help explain your problem.

image

Additional context
Note: The IP and token were changed and do not reflect the actual IP and token.

journalctl --follow

Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: INFO:     ('9.9.9.9', 0) - "WebSocket /ws/dashinfo/?access_token=5f37238aa54cc9c03ea6c640c9bec237bce126c4bc834c35fea21269db485841" 403
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: INFO:     connection failed (403 Forbidden)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ERROR:    Exception in ASGI application
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: Traceback (most recent call last):
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 247, in run_asgi
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     result = await self.app(self.scope, self.asgi_receive, self.asgi_send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await self.app(scope, receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/routing.py", line 62, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await application(scope, receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/tacticalrmm/tacticalrmm/utils.py", line 268, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await self.app(scope, receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/sessions.py", line 47, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await self.inner(dict(scope, cookies=cookies), receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/sessions.py", line 263, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await self.inner(wrapper.scope, receive, wrapper.send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/auth.py", line 185, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await super().__call__(scope, receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/middleware.py", line 24, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await self.inner(scope, receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/routing.py", line 116, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await application(
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 94, in app
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await consumer(scope, receive, send)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 58, in __call__
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await await_many_dispatch(
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/utils.py", line 50, in await_many_dispatch
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await dispatch(result)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 73, in dispatch
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await handler(message)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/generic/websocket.py", line 173, in websocket_connect
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await self.connect()
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/tacticalrmm/core/consumers.py", line 22, in connect
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await self.accept()
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/generic/websocket.py", line 186, in accept
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await super().send({"type": "websocket.accept", "subprotocol": subprotocol})
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 81, in send
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     await self.base_send(message)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/channels/sessions.py", line 226, in send
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     return await self.real_send(message)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:   File "/rmm/api/env/lib/python3.11/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 338, in asgi_send
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]:     raise RuntimeError(msg % message_type)
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: RuntimeError: Unexpected ASGI message 'websocket.accept', after sending 'websocket.close'.
Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: INFO:     connection closed
Originally created by @NiceGuyIT on GitHub (Nov 8, 2023). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1671 **Server Info (please complete the following information):** - OS: Ubuntu 20.04.4 LTS - Browser: Firefox 115.3.1esr - RMM Version (as shown in top left of web UI): v0.17.1 **Installation Method:** - [x] Standard - [ ] Docker **Agent Info (please complete the following information):** - Agent version (as shown in the 'Summary' tab of the agent from web UI): N/A - Agent OS: N/A **Describe the bug** This is a regression of #1199 with the `uvicorn` implementation. After upgrading the server, I kept getting the error below. The browser kept retrying the connection even though it received an error. Every retry caused an exception in the server logs. This will happen continuously as long as the browser is running. I.e. there is no way for the server to stop the client from retrying. **To Reproduce** Steps to reproduce the behavior: 1. Log in to the RMM. 2. Upgrade the server. I don't know if restarting will cause the same problem. 3. After the server is upgraded, follow the logs. `journalctl --follow` 4. See the error below. **Expected behavior** The client (browser) should not keep retrying if it receives an invalid status code from the server. In this case, it was `403 Forbidden` **Screenshots** If applicable, add screenshots to help explain your problem. ![image](https://github.com/amidaware/tacticalrmm/assets/7763429/170a72a4-175e-4fc6-9755-a9767e8dcc82) **Additional context** Note: The IP and token were changed and do not reflect the actual IP and token. `journalctl --follow` ```text Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: INFO: ('9.9.9.9', 0) - "WebSocket /ws/dashinfo/?access_token=5f37238aa54cc9c03ea6c640c9bec237bce126c4bc834c35fea21269db485841" 403 Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: INFO: connection failed (403 Forbidden) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ERROR: Exception in ASGI application Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: Traceback (most recent call last): Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 247, in run_asgi Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: result = await self.app(self.scope, self.asgi_receive, self.asgi_send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/uvicorn/middleware/proxy_headers.py", line 84, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await self.app(scope, receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/routing.py", line 62, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await application(scope, receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/tacticalrmm/tacticalrmm/utils.py", line 268, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await self.app(scope, receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/sessions.py", line 47, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await self.inner(dict(scope, cookies=cookies), receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/sessions.py", line 263, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await self.inner(wrapper.scope, receive, wrapper.send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/auth.py", line 185, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await super().__call__(scope, receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/middleware.py", line 24, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await self.inner(scope, receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/routing.py", line 116, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await application( Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 94, in app Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await consumer(scope, receive, send) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 58, in __call__ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await await_many_dispatch( Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/utils.py", line 50, in await_many_dispatch Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await dispatch(result) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 73, in dispatch Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await handler(message) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/generic/websocket.py", line 173, in websocket_connect Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await self.connect() Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/tacticalrmm/core/consumers.py", line 22, in connect Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await self.accept() Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/generic/websocket.py", line 186, in accept Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await super().send({"type": "websocket.accept", "subprotocol": subprotocol}) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/consumer.py", line 81, in send Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: await self.base_send(message) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/channels/sessions.py", line 226, in send Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: return await self.real_send(message) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: File "/rmm/api/env/lib/python3.11/site-packages/uvicorn/protocols/websockets/websockets_impl.py", line 338, in asgi_send Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: raise RuntimeError(msg % message_type) Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: RuntimeError: Unexpected ASGI message 'websocket.accept', after sending 'websocket.close'. Nov 08 08:44:22 ns-v35-tactical uvicorn[25990]: INFO: connection closed ```
kerem commented 2026-03-14 06:10:01 +03:00
Author
Owner
Copy link

@Trapulo commented on GitHub (Apr 22, 2024):

I have same problem, any way to fix?

<!-- gh-comment-id:2070039093 --> @Trapulo commented on GitHub (Apr 22, 2024): I have same problem, any way to fix?
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
develop
master
1.0.0
v1.4.0
v1.3.1
v1.3.0
v1.2.0
v1.1.0
v1.0.0
v0.20.1
v0.20.0
v0.19.4
v0.19.3
v0.19.2
v0.19.1
v0.19.0
v0.18.2
v0.18.1
v0.18.0
v0.17.5
v0.17.4
v0.17.3
v0.17.2
v0.17.1
v0.17.0
v0.16.5
v0.16.4
v0.16.3
v0.16.2
v0.16.1
v0.16.0
v0.15.12
v0.15.11
v0.15.10
v0.15.9
v0.15.8
v0.15.7
v0.15.6
v0.15.5
v0.15.4
v0.15.3
v0.15.2
v0.15.1
v0.15.0
v0.14.8
v0.14.7
v0.14.6
v0.14.5
v0.14.4
v0.14.3
v0.14.2
v0.14.1
v0.14.0
v0.13.4
v0.13.3
v0.13.2
v0.13.1
v0.13.0
v0.12.4
v0.12.3
v0.12.2
v0.12.1
v0.12.0
v0.11.3
v0.11.2
v0.11.1
v0.11.0
v0.10.5
v0.10.4
v0.10.3
v0.10.2
v0.10.1
v0.10.0
v0.9.2
v0.9.1
v0.9.0
v0.8.5
v0.8.4
v0.8.3
v0.8.2
v0.8.1
v0.8.0
v0.7.2
v0.7.1
v0.7.0
v0.6.15
v0.6.14
v0.6.13
v0.6.12
v0.6.11
v0.6.10
v0.6.9
v0.6.8
v0.6.7
v0.6.6
v0.6.5
v0.6.4
v0.6.3
v0.6.2
v0.6.1
v0.6.0
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.32
v0.4.31
v0.4.30
v0.4.29
v0.4.28
v0.4.27
v0.4.26
v0.4.25
v0.4.24
v0.4.23
v0.4.22
v0.4.21
v0.4.20
v0.4.19
v0.4.18
v0.4.17
v0.4.16
v0.4.15
v0.4.14
v0.4.13
v0.4.12
v0.4.11
v0.4.10
v0.4.9
v0.4.8
v0.4.7
v0.4.6
v0.4.5
v0.4.4
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.3
v0.3.2
v0.3.1
v0.3.0
v0.2.23
v0.2.22
v0.2.21
v0.2.20
v0.2.19
v0.2.18
v0.2.17
v0.2.16
v0.2.15
v0.2.14
v0.2.13
v0.2.12
v0.2.11
v0.2.10
v0.2.9
v0.2.8
v0.2.7
v0.2.6
v0.2.5
v0.2.4
v0.2.3
v0.2.2
v0.2.1
v0.2.0
v0.1.8
v0.1.7
v0.1.6
v0.1.5
v0.1.4
v0.1.3
v0.1.2
v0.1.1
v0.1.0
Labels
Clear labels   
In Process

   
bug

   
bug

   
dev-triage

   
documentation

   
duplicate

   
enhancement

   
fixed

   
good first issue

   
help wanted

   
integration

   
invalid

   
pull-request

Mirrored from GitHub Pull Request

  
question

   
requires agent update

   
security

   
ui tweak

   
wontfix
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#2987
No description provided.