mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 06:55:52 +03:00
[GH-ISSUE #1105] Reestablish tasks running at first opportunity if missed because it's in the past or was offline at the time of task #2623
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2623
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @silversword411 on GitHub (Apr 28, 2022).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1105
Originally assigned to: @silversword411 on GitHub.
Re-establishing this feature:
https://github.com/amidaware/tacticalrmm/issues/247
Will fix 2 cases:
@sadnub commented on GitHub (Apr 29, 2022):
I believe this is already implemented. Run once tasks will created in the future on agents if the time is in the past. There is also a Run ASAP after missed check box that you can use for tasks to run if missed
@silversword411 commented on GitHub (Apr 29, 2022):
When do they get calculated and run properly? This is just one example of...lots. These automations have been around for a while, do I need to delete/recreate them maybe?
@wh1te909 commented on GitHub (May 10, 2022):
just tested and working for me, please watch the attached GIF and at the end you'll see the task gets set to run at 5 minutes past the current time. might need to recreate from scratch
@silversword411 commented on GitHub (May 11, 2022):
Can't scrub and re-watch specific portions of animated .gifs, so hard to catch details at a specific portion...but I don't think the problem is TRMM creating the event. It's doing everything that it's been told to do.
I think the fundamental problem is that windows isn't/doesn't respect the "run if missed" flag if the event is created with a time in the past (via api?) and the computer pass over that time at least once to put it into it's task queue.
This picture is of the 2021 event that was created 4/29/2022. Why hasn't it run yet? It's in the past, it's got the "Run task as soon as possible after the scheduled start is missed".
Still hasn't run though.
I wonder if we can find out why these events aren't run in windows....or maybe there should just be an official "onboarding" process if we can't get it running reliably?
@wh1te909 commented on GitHub (May 11, 2022):
I have attached a video now. Yes windows will not run if missed unless the time has already passed, so to get around that, when you create the task using trmm and set the date in the past, trmm will notice that the date is in the past, and change it to the current time + 5 minutes, before sending it to the agent. So it will be created with a date in the future, not past (in trmm web UI it will show the past time, we need to fix that, but if you look in task scheduler the time will be in the future, as shown in the video).
https://user-images.githubusercontent.com/7434746/167910768-f7bccce3-6b4b-4fca-83ef-055c0cc59a5f.mp4
@silversword411 commented on GitHub (May 11, 2022):
Yeah....so it's the time of windows task creation that does the 5min workaround dance...and these aren't working because they're 4/25 created tasks (which might be <v0.13.3 tasks).
Now I know the 5min thing, Let me see if I can get it working without completely rebuilding all the automation ;)
@silversword411 commented on GitHub (May 17, 2022):
Confirmed working with newly created tasks