[GH-ISSUE #1044] Have some kind of indicator for scripts that download 3rd party resources #2581

Open
opened 2026-03-14 04:40:48 +03:00 by kerem · 4 comments
Owner

Originally created by @silversword411 on GitHub (Apr 2, 2022).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1044

Originally assigned to: @sadnub on GitHub.

We were discussing scripts that do downloads of other non-tracked programs (like https://github.com/amidaware/community-scripts/blob/main/scripts/Win_Network_Speed_Test.ps1 )

Should we have some kind of indictor (*, colorize it differently in the library etc) so it'll queue people to double-check it.

Originally created by @silversword411 on GitHub (Apr 2, 2022). Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1044 Originally assigned to: @sadnub on GitHub. We were discussing scripts that do downloads of other non-tracked programs (like https://github.com/amidaware/community-scripts/blob/main/scripts/Win_Network_Speed_Test.ps1 ) Should we have some kind of indictor (*, colorize it differently in the library etc) so it'll queue people to double-check it.
Author
Owner

@dinger1986 commented on GitHub (Apr 3, 2022):

I was thinking an !

Also if we could add a way to download testing scripts as well?

<!-- gh-comment-id:1086826929 --> @dinger1986 commented on GitHub (Apr 3, 2022): I was thinking an `!` Also if we could add a way to download testing scripts as well?
Author
Owner

@bbrendon commented on GitHub (Apr 3, 2022):

maybe have a value in the script json database that triggers a GUI element.

<!-- gh-comment-id:1086916083 --> @bbrendon commented on GitHub (Apr 3, 2022): maybe have a value in the script json database that triggers a GUI element.
Author
Owner

@sadnub commented on GitHub (Apr 16, 2022):

Could we just search the script body and args for [protocol]:// and automatically return to the UI that the script references external resources? This would make it automatic and keep maintenance down.

<!-- gh-comment-id:1100755192 --> @sadnub commented on GitHub (Apr 16, 2022): Could we just search the script body and args for `[protocol]://` and automatically return to the UI that the script references external resources? This would make it automatic and keep maintenance down.
Author
Owner

@dinger1986 commented on GitHub (Apr 16, 2022):

Absolutely, whatever works easiest. Think the main thing is agreeing on an indicator

<!-- gh-comment-id:1100755459 --> @dinger1986 commented on GitHub (Apr 16, 2022): Absolutely, whatever works easiest. Think the main thing is agreeing on an indicator
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/tacticalrmm#2581
No description provided.