mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 23:15:57 +03:00
[GH-ISSUE #675] BUG: Save results to Agent Notes only recording "NULL" in audit log details #2373
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2373
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @manc74 on GitHub (Aug 31, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/675
Server Info (please complete the following information):
Installation Method:
Agent Info (please complete the following information):
Describe the bug
When executing a script, the new option to save results to agent notes only records "NULL" in the details panel.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The same output on the run pane should be displayed in the audit details pane.
Screenshots

Additional context
Add any other context about the problem here.
@wh1te909 commented on GitHub (Sep 1, 2021):
I don't think the script output is meant to be stored in the audit log, so this really isn't a bug more like a feature request. @sadnub will correct me if i'm wrong
it's already stored in the "History" tab which we added so that there is always a history of every script/cmd that was run and it's output
And if you are saving it to Notes then it will be stored there as well
adding it to audit log is overkill IMO
@subzdev commented on GitHub (Sep 1, 2021):
I would agree it does seem to be overkill, but if everything is null in the modal window probably no need to even have the ability to click at all for audit log entries?
@wh1te909 commented on GitHub (Sep 1, 2021):
there are still use cases for clicking, like if you edit an agent you can see the before and after values to see what changed. maybe if it's null we can make it not clickable
@manc74 commented on GitHub (Sep 1, 2021):
Ah ok, I was looking in the wrong tab for the output, just assumed it would be in the audit tab - I can see the history output fine in the history tab now.