mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 06:55:52 +03:00
[GH-ISSUE #618] Feature: use login token for meshcentral integration #2338
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2338
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @bbrendon on GitHub (Jul 4, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/618
I would like to require mesh to have 2fa enabled ("force2factor": true) but not break the integration with tactical.
Mesh has the ability to force 2fa but enabling it breaks the integration with tactical. From my understanding, in order to to resolve this tactical can use login tokens for the mesh API.
https://github.com/Ylianst/MeshCentral/issues/2859#issuecomment-873631301
@wh1te909 commented on GitHub (Jul 21, 2021):
tactical is already using login tokens that's how we integrate with mesh
i just tried adding
"force2factor": trueto my config.json, restarted mesh and confirmed didn't break anything. iframe integration still works. but when trying to login now with just username/pass from the mesh login screen, am prompted for 2 factor. not sure why it's breaking for you, can you post your config.json@bbrendon commented on GitHub (Jul 21, 2021):
Sorry, I should have been more specific...
There is an auth-popup with breaks the seamlessness of the integration.
Also, even though I'm logged into the mesh interface using 2fa in one browser tab, when I go to Tactical and it opens a mesh iframe, I get this...
So maybe the admin account needs 2fa? And the 2fa sign-up QR Code needs to be saved and sent to all the users? But then that goes back to sharing accounts which kind of defeats the purpose.
All of this seems backwards. It seems like each user should input their mesh API token into Tactical that creates the integration.
@bbrendon commented on GitHub (Sep 23, 2021):
I just noticed this issue which might be related. https://github.com/wh1te909/tacticalrmm/issues/182
@dinger1986 commented on GitHub (Oct 11, 2021):
A decent work round for now is:
They now can’t disable MFA
@fts-tmassey commented on GitHub (Apr 11, 2022):
Sorry: this isn't the right issue for this, though it is relevant. Moved comment to https://github.com/amidaware/tacticalrmm/issues/182#issuecomment-1095422533
tl;dr: Adding PR #981 allows admin to manage remote control permissions for the techs individually; adding ability to add mesh_device_group to site in addition to globally allows TRMM to automatically put the device in the right Mesh group, which gives you 100% permission control with zero ongoing manual effort.
Sorry for the extra noise. Too many open tabs! :)