mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 15:05:57 +03:00
[GH-ISSUE #490] Bug: Lenovo Systems don't Display proper model number #2246
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2246
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @johnnyq on GitHub (May 10, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/490
Originally assigned to: @wh1te909 on GitHub.
Server Info (please complete the following information):
Installation Method:
Agent Info (please complete the following information):
Describe the bug
All Lenovo Systems display the improper model number under summary > hardware details.
For example I have a computer Lenovo ThinkPad E560 that displays LENOVO 20EV002JUS under summary > hardware details.
Digging further if you click on Assets > Computer System The model number is listed as 20EV002JUS but if you scroll down further there is a variable called SystemFamily which gives the correct model ThinkPad E560.
I think a fix for this would be a logic statement
if Manufacturer = Lenovo then Model = SystemFamily
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Display SystemFamily instead of Model for Lenovo Systems
@johnnyq commented on GitHub (May 10, 2021):
Looking through more Lenovo Agents we noticed 3 out 30 Lenovo Systems have
the variable SystemFamily as To be filled by O.E.M. under Summary > Computer System
So another Logic statement would be If SystemFamily = To be filled by O.E.M. then use Model Field for all Lenovo Computers
@dinger1986 commented on GitHub (May 10, 2021):
Hello, can you check the serial numbers against the machines on mesh, are they right?
@johnnyq commented on GitHub (May 10, 2021):
@dinger1986 will check and report back
@dinger1986 commented on GitHub (May 10, 2021):
I'll be honest it's only from interest, but if it does work then should be able to find out how they are doing it, if it doesn't then helps them as well!
@wh1te909 commented on GitHub (May 11, 2021):
sounds good thanks for the logic statement, will implement that
@wh1te909 commented on GitHub (May 11, 2021):
@johnnyq i've implemented this see the commit above, if you can please try it out and lmk. just edit that file on your prod server and add the changes i made, and then do a
sudo systemctl restart rmmand refresh your dashboard and lmk if looks good@wh1te909 commented on GitHub (May 12, 2021):
released in 0.6.9 i tested on a lenovo laptop
@johnnyq commented on GitHub (May 12, 2021):
@wh1te909 That is fantastic!! Thanks it works so much better now!! =]