mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 06:55:52 +03:00
[GH-ISSUE #444] Ping check error #2215
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2215
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @NicolasDEVOUGE on GitHub (Apr 28, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/444
Originally assigned to: @wh1te909 on GitHub.
Server Info (please complete the following information):
Installation Method:
Agent Info (please complete the following information):
Describe the bug
Ping check script report error but ping is ok
To Reproduce
Steps to reproduce the behavior:
Screenshots

@dinger1986 commented on GitHub (Apr 28, 2021):
My pings are working fine.
I wonder if it's a localisation issue.
@NicolasDEVOUGE commented on GitHub (Apr 28, 2021):
Yes, maybe it's because my ping is in french. I don't know how to see the source of the script to check that.
@dinger1986 commented on GitHub (Apr 28, 2021):
Yeah probably is, I dont know, just hoping that helps the devs, guess it should be worked on allong with #39 if that is the case
@wh1te909 commented on GitHub (Apr 29, 2021):
yea im using windows' ping.exe and checking for english strings only atm
this will be fixed in the next agent, im switching to a pure go icmp implementation rather than checking the output for certain keywords to determine pass/fail status
@wh1te909 commented on GitHub (Apr 30, 2021):
This has been fixed in latest release. Requires agent v1.5.3
@NicolasDEVOUGE commented on GitHub (Apr 30, 2021):
That's working perfectly, thank you !