mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 15:05:57 +03:00
[GH-ISSUE #360] Community script library - enhancements to unique ID and managing community script library changes/deletes #2168
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2168
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @silversword411 on GitHub (Apr 2, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/360
From discord chat, my understanding is community scripts on first install are converted to base64 and imported into the database. The unique key is the "name": field. If that is changed then it will think it's a new script and can break things.
First
Add new field in
community_scripts.jsonuuid:that will be the unique database identifier (need method of creating it the first time).Second
Update script needs to be fixed so that:
All community scripts database entries unique key is changed from
name:touuid:Third
Update script needs to be fixed so that:
If a community script is deleted (uuid: no longer there) and is not in use purge from local database
OR
If a community script is deleted (uuid: no longer there) AND it's currently in use in the local install the script should be converted from a community (unmodifiable) script to a userdefined script (so we don't break existing automation profiles).