mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 06:55:52 +03:00
[GH-ISSUE #288] Software installation dates showing as 0001-01-01 #2133
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#2133
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @djsvi on GitHub (Feb 22, 2021).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/288
Originally assigned to: @wh1te909 on GitHub.
Many (but not all) software installations are displaying a date of 0001-01-01. I have confirmed correct dates are showing under control panel > add/remove programs.
Any ideas?
@aftechro commented on GitHub (Feb 23, 2021):
same here
@wh1te909 commented on GitHub (Feb 25, 2021):
check the following 2 registry paths
HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\UninstallHKLM\SOFTWARE\Wow6432Node\Microsoft\Windows\CurrentVersion\UninstallFor software that's showing 0001-01-01, you'll notice they are missing the
InstallDatestring value.It's the responsibility of the software developer to make sure they set the
InstallDatevalue in their installer.It shows up in control panel cuz Windows is getting it from somewhere else, maybe WMI but not 100% sure.
This is pretty low priority for me atm, so if you guys wanna research and see where else I can check for an install date let me know.
@djsvi commented on GitHub (Mar 6, 2021):
I have looked into this. Apparently if the value of InstallDate isn't populated for an application then Add/Remove Programs simply looks up the 'last write time' for that application's registry key and uses that. Since I note you're referencing 3rd party code to generate the installed applications list, it might be better to have them incorporate that kind of change.
Two side points on this (not wishing to deviate too far from the original issue):
Cheers.
@wh1te909 commented on GitHub (Mar 6, 2021):
@djsvi thanks for that! i'll look into getting the last write time.
For the date format I had the same idea lol, I think you're still on an old version of the RMM because in latest version i already changed the date format to match what shows up in control panel add/remove programs. So just update to latest version and once your agents update you'll see the new date format.
Yea the uninstall string is currently stored in the rmm's database just not displaying it in the UI yet. Was thinking to add an "uninstall" button next to each software and just have it call the uninstall cmd
@djsvi commented on GitHub (Mar 6, 2021):
Thanks @wh1te909, I've updated and the new date format is showing, but it's in US date format.. might have been better to use YYYY-MM-DD which is more universally recognised. Otherwise a 'date format' setting under user preferences would allow you to display the user's preferred format everywhere, but I guess would require a bunch of extra code.
With the uninstall string - a button would be good if it allows 1) the string to be copied to clipboard, say for later use in a script and 2) modification of the string before it gets executed on the agent, as there are often additional parameters needed for truly silent uninstallation.
@wh1te909 commented on GitHub (Mar 7, 2021):
Ok i'll change it to
YYYY-MM-DDformat in the next agent. User preference for date would be nice we can add that later.And sounds good for the uninstall stuff I can definitely implement those
@djsvi commented on GitHub (Mar 7, 2021):
Great! Can I suggest keeping all dates/times in UTC / 'native' format in the agent and database and then applying the required formatting at display time, i.e. this should (generally) be a UI change, not an agent change.
@wh1te909 commented on GitHub (Mar 7, 2021):
yes this is how we already do it currently for the majority of things, dates are all stored as UTC and then are converted and displayed in the web UI based on the agent's timezone which you can set per agent. In this case however I just did a quick temp fix since for the installed software, since the software list is stored as just a simple json field in the db, not creating a separate row for each software which then i could add a datetime db field. Not super priority atm but eventually can rework it.
@subzdev commented on GitHub (Apr 28, 2021):
Having an uninstall button would be a REALLY nice feature IMO.
@silversword411 commented on GitHub (Sep 21, 2021):
Not sure if this is complete (date addition is) or it if's still in-process because of the "add uninstall button" addon.
Add uninstall button could auto-run this auto-magically: https://github.com/wh1te909/tacticalrmm/blob/develop/scripts/Win_Software_Uninstall.ps1