[PR #1277] [MERGED] When checking if patches are to be installed, don't exit the function after finding a patched machine. #1843

New issue

Closed

opened 2026-03-02 02:24:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:24:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/1277
Author: @af7567
Created: 9/6/2022
Status: ✅ Merged
Merged: 9/6/2022
Merged by: @wh1te909

Base: develop ← Head: winupdatesfix

📝 Commits (1)

28f6838 continue to next agent rather than return from function, otherwise other agents won't receive updates

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 api/tacticalrmm/winupdate/tasks.py (+1 -1)

📄 Description

Currently check_agent_update_schedule_task() will return after finding a machine which has already been patched the same day, this prevents any agents later in the list getting updates.

Returning is ok if only 1 patch policy triggers per day, but if client1 patches at 03:00 and client2 patches at 19:00 then client2 won't get all patches if any agents from client1 are online.

Fixes #1270

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/1277 **Author:** [@af7567](https://github.com/af7567) **Created:** 9/6/2022 **Status:** ✅ Merged **Merged:** 9/6/2022 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `winupdatesfix` --- ### 📝 Commits (1) - [`28f6838`](https://github.com/amidaware/tacticalrmm/commit/28f68385603bb0b4b490cdb4747fc37b3244e048) continue to next agent rather than return from function, otherwise other agents won't receive updates ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/tacticalrmm/winupdate/tasks.py` (+1 -1) </details> ### 📄 Description Currently `check_agent_update_schedule_task()` will return after finding a machine which has already been patched the same day, this prevents any agents later in the list getting updates. Returning is ok if only 1 patch policy triggers per day, but if client1 patches at 03:00 and client2 patches at 19:00 then client2 won't get all patches if any agents from client1 are online. Fixes #1270 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>