[PR #1179] [CLOSED] Add option to enable Proxy Protocol on Docker/K8s setups #1834

New issue

Closed

opened 2026-03-02 02:24:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:24:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/1179
Author: @joeldeteves
Created: 6/20/2022
Status: ❌ Closed

Base: develop ← Head: proxy_protocol

📝 Commits (1)

bc31b2f Add option to enable Proxy Protocol on Docker/K8s setups

📊 Changes

1 file changed (+30 additions, -8 deletions)

View changed files

📝 docker/containers/tactical-nginx/entrypoint.sh (+30 -8)

📄 Description

This PR addresses the enhancement request in #1057 as follows:

Enable Proxy Protocol using an environment variable PROXY_PROTOCOL_ENABLED="yes"
Set Trusted IP for upstream Load Balancer using PROXY_PROTOCOL_TRUSTED_IP="127.0.0.1"
Default to original values / not enabled

PS - @silversword411 this is as best I can come up with but if you can think of a cleaner way to do it I'm happy to make those changes.

-JD

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/1179 **Author:** [@joeldeteves](https://github.com/joeldeteves) **Created:** 6/20/2022 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `proxy_protocol` --- ### 📝 Commits (1) - [`bc31b2f`](https://github.com/amidaware/tacticalrmm/commit/bc31b2f8232cdaaede083a932e5d3daeb3c2eed9) Add option to enable Proxy Protocol on Docker/K8s setups ### 📊 Changes **1 file changed** (+30 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `docker/containers/tactical-nginx/entrypoint.sh` (+30 -8) </details> ### 📄 Description This PR addresses the enhancement request in #1057 as follows: - Enable Proxy Protocol using an environment variable `PROXY_PROTOCOL_ENABLED="yes"` - Set Trusted IP for upstream Load Balancer using `PROXY_PROTOCOL_TRUSTED_IP="127.0.0.1"` - Default to original values / not enabled PS - @silversword411 this is as best I can come up with but if you can think of a cleaner way to do it I'm happy to make those changes. -JD --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>