[PR #269] [MERGED] WIP - Feature alerts #1577

New issue

Closed

opened 2026-03-02 02:23:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:23:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/269
Author: @sadnub
Created: 2/6/2021
Status: ✅ Merged
Merged: 2/12/2021
Merged by: @wh1te909

Base: develop ← Head: feature-alerts

📝 Commits (10+)

6f3b6fa alerts wip
f1f999f more alerts work
669e638 automation manager rework start
3fe83f8 migrations fix and finishing up automation manager rework
db5ff37 alerts overview work
99d3a8a more alerts work
66d7172 reworked policy add for client, site, and agent. removed vue unit tests, added alertign to auto tasks, added edit autotask capabilities for certain fields, moved policy generation logic to save method on Client, Site, Agent, Policy models
371b764 added new alert option for dashboard alerts, added actions to be run if alert triggered on agent, random fixes
ac058e9 fixed alerts manager table, added celery task to unsnooze alerts, added bulk actions to alerts overview
a5f123b bug fixes with automated manager deleting policies and adding

📊 Changes

124 files changed (+7936 additions, -4636 deletions)

View changed files

📝 .devcontainer/.env.example (+2 -2)
📝 .devcontainer/docker-compose.yml (+2 -0)
📝 .devcontainer/entrypoint.sh (+15 -16)
📝 api/tacticalrmm/agents/admin.py (+1 -2)
📝 api/tacticalrmm/agents/baker_recipes.py (+6 -4)
➕ api/tacticalrmm/agents/migrations/0027_agent_overdue_dashboard_alert.py (+18 -0)
➕ api/tacticalrmm/agents/migrations/0028_auto_20210206_1534.py (+23 -0)
➕ api/tacticalrmm/agents/migrations/0029_delete_agentoutage.py (+16 -0)
📝 api/tacticalrmm/agents/models.py (+336 -31)
📝 api/tacticalrmm/agents/serializers.py (+10 -1)
📝 api/tacticalrmm/agents/tasks.py (+73 -44)
📝 api/tacticalrmm/agents/tests.py (+2 -4)
📝 api/tacticalrmm/agents/views.py (+33 -31)
📝 api/tacticalrmm/alerts/admin.py (+2 -1)
📝 api/tacticalrmm/alerts/migrations/0001_initial.py (+1 -1)
📝 api/tacticalrmm/alerts/migrations/0002_auto_20200815_1618.py (+1 -1)
📝 api/tacticalrmm/alerts/migrations/0003_auto_20201021_1815.py (+1 -1)
➕ api/tacticalrmm/alerts/migrations/0004_auto_20210212_1408.py (+172 -0)
➕ api/tacticalrmm/alerts/migrations/0005_auto_20210212_1745.py (+31 -0)
📝 api/tacticalrmm/alerts/models.py (+246 -5)

...and 80 more files

📄 Description

Added Functionality

Centrally manage alerts with policies
Can override global email/sms settings from alert templates #67
Added new dashboard alert type
Added additional alert states: info, warning, and error #184
Added ability to snooze and resolve alerts in dashboard
Added Alerts overview to manage and view dashboard alerts
Run a script on agent when alert fails #89 #116
Added ability to run scripts on resolved alerts
Added same alerting to automated tasks
Added periodic notifications
Added ability to send resolved emails/sms when alert is fixed #168

Modifications

Reworked automation frontend to use qdialog plugin and removed vuex module
Moved some automation policy logic to the save method on models to reduce bugs and race conditions

Bug fixes

Found an issue with pending actions getting stuck if other pending action types were present
Fixed an issue if a policy check associated with a task was overridden by an agent
Other minor fixes and improvements
Fix diskspace check history #274

TODO

Implement resolved/failed script actions on alert
Implement core mail settings override
make sure error and warning thresholds work in check add/edit modals
fix tests
alerts view tests
add UI in alerts overview to view action failure/resolved script run output
alert tasks and notification tests in agents, checks, and tasks

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/269 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 2/6/2021 **Status:** ✅ Merged **Merged:** 2/12/2021 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `feature-alerts` --- ### 📝 Commits (10+) - [`6f3b6fa`](https://github.com/amidaware/tacticalrmm/commit/6f3b6fa9cef86f73018d8f13c4f0a5f162e0f1f8) alerts wip - [`f1f999f`](https://github.com/amidaware/tacticalrmm/commit/f1f999f3b690f07b5d488f64f5a7b90cf0ee4c9c) more alerts work - [`669e638`](https://github.com/amidaware/tacticalrmm/commit/669e638fd6ca27baa983fdadaf1525f370a6220c) automation manager rework start - [`3fe83f8`](https://github.com/amidaware/tacticalrmm/commit/3fe83f81be3371240c9cd1e0a194e442c8a47dc7) migrations fix and finishing up automation manager rework - [`db5ff37`](https://github.com/amidaware/tacticalrmm/commit/db5ff372a45552e4428b98fdcd4fd9af226efa79) alerts overview work - [`99d3a8a`](https://github.com/amidaware/tacticalrmm/commit/99d3a8a7497c7f14e35a0528cf4200c9470bf036) more alerts work - [`66d7172`](https://github.com/amidaware/tacticalrmm/commit/66d7172e094180ee60ad5982255caa3fb2ce1b07) reworked policy add for client, site, and agent. removed vue unit tests, added alertign to auto tasks, added edit autotask capabilities for certain fields, moved policy generation logic to save method on Client, Site, Agent, Policy models - [`371b764`](https://github.com/amidaware/tacticalrmm/commit/371b764d1d3125594495cf1a109d9eb24e2bde4f) added new alert option for dashboard alerts, added actions to be run if alert triggered on agent, random fixes - [`ac058e9`](https://github.com/amidaware/tacticalrmm/commit/ac058e96755e7669087a80cb5734a519cd78ae36) fixed alerts manager table, added celery task to unsnooze alerts, added bulk actions to alerts overview - [`a5f123b`](https://github.com/amidaware/tacticalrmm/commit/a5f123b9ce6879bceca7f85f282a3703c71ed87c) bug fixes with automated manager deleting policies and adding ### 📊 Changes **124 files changed** (+7936 additions, -4636 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/.env.example` (+2 -2) 📝 `.devcontainer/docker-compose.yml` (+2 -0) 📝 `.devcontainer/entrypoint.sh` (+15 -16) 📝 `api/tacticalrmm/agents/admin.py` (+1 -2) 📝 `api/tacticalrmm/agents/baker_recipes.py` (+6 -4) ➕ `api/tacticalrmm/agents/migrations/0027_agent_overdue_dashboard_alert.py` (+18 -0) ➕ `api/tacticalrmm/agents/migrations/0028_auto_20210206_1534.py` (+23 -0) ➕ `api/tacticalrmm/agents/migrations/0029_delete_agentoutage.py` (+16 -0) 📝 `api/tacticalrmm/agents/models.py` (+336 -31) 📝 `api/tacticalrmm/agents/serializers.py` (+10 -1) 📝 `api/tacticalrmm/agents/tasks.py` (+73 -44) 📝 `api/tacticalrmm/agents/tests.py` (+2 -4) 📝 `api/tacticalrmm/agents/views.py` (+33 -31) 📝 `api/tacticalrmm/alerts/admin.py` (+2 -1) 📝 `api/tacticalrmm/alerts/migrations/0001_initial.py` (+1 -1) 📝 `api/tacticalrmm/alerts/migrations/0002_auto_20200815_1618.py` (+1 -1) 📝 `api/tacticalrmm/alerts/migrations/0003_auto_20201021_1815.py` (+1 -1) ➕ `api/tacticalrmm/alerts/migrations/0004_auto_20210212_1408.py` (+172 -0) ➕ `api/tacticalrmm/alerts/migrations/0005_auto_20210212_1745.py` (+31 -0) 📝 `api/tacticalrmm/alerts/models.py` (+246 -5) _...and 80 more files_ </details> ### 📄 Description Added Functionality - Centrally manage alerts with policies - Can override global email/sms settings from alert templates #67 - Added new dashboard alert type - Added additional alert states: info, warning, and error #184 - Added ability to snooze and resolve alerts in dashboard - Added Alerts overview to manage and view dashboard alerts - Run a script on agent when alert fails #89 #116 - Added ability to run scripts on resolved alerts - Added same alerting to automated tasks - Added periodic notifications - Added ability to send resolved emails/sms when alert is fixed #168 Modifications - Reworked automation frontend to use qdialog plugin and removed vuex module - Moved some automation policy logic to the save method on models to reduce bugs and race conditions Bug fixes - Found an issue with pending actions getting stuck if other pending action types were present - Fixed an issue if a policy check associated with a task was overridden by an agent - Other minor fixes and improvements - Fix diskspace check history #274 TODO - [x] Implement resolved/failed script actions on alert - [x] Implement core mail settings override - [x] make sure error and warning thresholds work in check add/edit modals - [x] fix tests - [x] alerts view tests - [x] add UI in alerts overview to view action failure/resolved script run output - [ ] alert tasks and notification tests in agents, checks, and tasks --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>