[PR #159] [MERGED] some features, fixes, and tests #1549

New issue

Closed

opened 2026-03-02 02:23:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:23:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/159
Author: @sadnub
Created: 10/30/2020
Status: ✅ Merged
Merged: 10/31/2020
Merged by: @wh1te909

Base: develop ← Head: develop

📝 Commits (9)

b7069f9 feat: allow one time tasks and added task cleanup script. Various fixes and rework
bf9efc7 bump app version
962754f test start
77fd0bc finish autotask view tests
ba9a4c7 black formatting
e09ad7e only send task to online agents
4b9030c remove signal to fix recursion error, moved to a periodic task
571a301 fix orphaned tasks
85d23fa add orphaned task test

📊 Changes

30 files changed (+603 additions, -144 deletions)

View changed files

📝 api/tacticalrmm/agents/baker_recipes.py (+1 -1)
📝 api/tacticalrmm/agents/migrations/0015_auto_20200922_1344.py (+9 -9)
📝 api/tacticalrmm/agents/migrations/0015_note.py (+31 -7)
📝 api/tacticalrmm/agents/migrations/0016_merge_20200923_0225.py (+3 -4)
📝 api/tacticalrmm/agents/migrations/0017_auto_20201016_0629.py (+23 -23)
📝 api/tacticalrmm/agents/migrations/0018_auto_20201023_1956.py (+11 -11)
📝 api/tacticalrmm/agents/migrations/0019_agent_maintenace_mode.py (+3 -3)
📝 api/tacticalrmm/agents/migrations/0020_auto_20201025_2129.py (+4 -4)
📝 api/tacticalrmm/agents/serializers.py (+1 -1)
📝 api/tacticalrmm/agents/views.py (+1 -1)
📝 api/tacticalrmm/automation/models.py (+5 -1)
📝 api/tacticalrmm/automation/serializers.py (+1 -3)
📝 api/tacticalrmm/automation/tests.py (+0 -1)
➕ api/tacticalrmm/autotasks/management/commands/remove_orphaned_tasks.py (+19 -0)
📝 api/tacticalrmm/autotasks/migrations/0006_auto_20200922_1344.py (+9 -9)
➕ api/tacticalrmm/autotasks/migrations/0007_auto_20201029_1410.py (+37 -0)
➕ api/tacticalrmm/autotasks/migrations/0008_auto_20201030_1515.py (+26 -0)
📝 api/tacticalrmm/autotasks/models.py (+11 -4)
📝 api/tacticalrmm/autotasks/tasks.py (+76 -0)
📝 api/tacticalrmm/autotasks/tests.py (+238 -2)

...and 10 more files

📄 Description

Fixes #97 Added a management command to remove orphaned checks on agents. python manage.py remove_orphaned_tasks
Fixes #109 Allows for Run Once task and can optionally remove the task after execution

Fixes a case where duplicate policy tasks will be created on agents

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/159 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 10/30/2020 **Status:** ✅ Merged **Merged:** 10/31/2020 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (9) - [`b7069f9`](https://github.com/amidaware/tacticalrmm/commit/b7069f9907de1fae09ac2b8d6474b5ec908b8cf0) feat: allow one time tasks and added task cleanup script. Various fixes and rework - [`bf9efc7`](https://github.com/amidaware/tacticalrmm/commit/bf9efc70cffacddd0b1e7835aab6d0db26480b0c) bump app version - [`962754f`](https://github.com/amidaware/tacticalrmm/commit/962754fd80390da74fe246a77e353cbbbdf8e35a) test start - [`77fd0bc`](https://github.com/amidaware/tacticalrmm/commit/77fd0bccc02775bf2fefbe6625f8a1d157d10dab) finish autotask view tests - [`ba9a4c7`](https://github.com/amidaware/tacticalrmm/commit/ba9a4c7e1a5299ceeccb56740ec05f571ff3394b) black formatting - [`e09ad7e`](https://github.com/amidaware/tacticalrmm/commit/e09ad7ed23693d390778edad5b1d2364892f620b) only send task to online agents - [`4b9030c`](https://github.com/amidaware/tacticalrmm/commit/4b9030cadfab7b990ce29adb17da766adb4a4bb6) remove signal to fix recursion error, moved to a periodic task - [`571a301`](https://github.com/amidaware/tacticalrmm/commit/571a301989888a3bccd70024f8997b82a5c67308) fix orphaned tasks - [`85d23fa`](https://github.com/amidaware/tacticalrmm/commit/85d23fa925dab024bd0184b943d88cf734d17356) add orphaned task test ### 📊 Changes **30 files changed** (+603 additions, -144 deletions) <details> <summary>View changed files</summary> 📝 `api/tacticalrmm/agents/baker_recipes.py` (+1 -1) 📝 `api/tacticalrmm/agents/migrations/0015_auto_20200922_1344.py` (+9 -9) 📝 `api/tacticalrmm/agents/migrations/0015_note.py` (+31 -7) 📝 `api/tacticalrmm/agents/migrations/0016_merge_20200923_0225.py` (+3 -4) 📝 `api/tacticalrmm/agents/migrations/0017_auto_20201016_0629.py` (+23 -23) 📝 `api/tacticalrmm/agents/migrations/0018_auto_20201023_1956.py` (+11 -11) 📝 `api/tacticalrmm/agents/migrations/0019_agent_maintenace_mode.py` (+3 -3) 📝 `api/tacticalrmm/agents/migrations/0020_auto_20201025_2129.py` (+4 -4) 📝 `api/tacticalrmm/agents/serializers.py` (+1 -1) 📝 `api/tacticalrmm/agents/views.py` (+1 -1) 📝 `api/tacticalrmm/automation/models.py` (+5 -1) 📝 `api/tacticalrmm/automation/serializers.py` (+1 -3) 📝 `api/tacticalrmm/automation/tests.py` (+0 -1) ➕ `api/tacticalrmm/autotasks/management/commands/remove_orphaned_tasks.py` (+19 -0) 📝 `api/tacticalrmm/autotasks/migrations/0006_auto_20200922_1344.py` (+9 -9) ➕ `api/tacticalrmm/autotasks/migrations/0007_auto_20201029_1410.py` (+37 -0) ➕ `api/tacticalrmm/autotasks/migrations/0008_auto_20201030_1515.py` (+26 -0) 📝 `api/tacticalrmm/autotasks/models.py` (+11 -4) 📝 `api/tacticalrmm/autotasks/tasks.py` (+76 -0) 📝 `api/tacticalrmm/autotasks/tests.py` (+238 -2) _...and 10 more files_ </details> ### 📄 Description Fixes #97 Added a management command to remove orphaned checks on agents. python manage.py remove_orphaned_tasks Fixes #109 Allows for Run Once task and can optionally remove the task after execution Fixes a case where duplicate policy tasks will be created on agents --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>