[PR #115] [MERGED] Added Audit Log Support #1531

New issue

Closed

opened 2026-03-02 02:23:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 02:23:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/amidaware/tacticalrmm/pull/115
Author: @sadnub
Created: 9/23/2020
Status: ✅ Merged
Merged: 9/24/2020
Merged by: @wh1te909

Base: develop ← Head: develop

📝 Commits (10+)

86bfcb7 docker dev and test changes
fe8fb74 totp setup rework
2b2cb85 core model changes
d17f5df WIP added audit logging support
7030c18 fix duplicate audit log entries
e974845 merge migration conflict
5dd73e7 fix tests
f2516fe fixed administration page and generated a unique signal uid per request
2bd6d66 fixed named parameter bug
88fea13 added auditing to user successful and failed attempts. Set audit log timezone to the default in core settings

📊 Changes

53 files changed (+1354 additions, -288 deletions)

View changed files

➕ api/tacticalrmm/accounts/migrations/0003_auto_20200922_1344.py (+33 -0)
📝 api/tacticalrmm/accounts/models.py (+11 -0)
📝 api/tacticalrmm/accounts/views.py (+16 -6)
➕ api/tacticalrmm/agents/migrations/0015_auto_20200922_1344.py (+33 -0)
➕ api/tacticalrmm/agents/migrations/0016_merge_20200923_0225.py (+14 -0)
📝 api/tacticalrmm/agents/models.py (+13 -0)
📝 api/tacticalrmm/agents/urls.py (+1 -0)
📝 api/tacticalrmm/agents/views.py (+37 -1)
📝 api/tacticalrmm/api/urls.py (+0 -1)
📝 api/tacticalrmm/api/views.py (+0 -24)
➕ api/tacticalrmm/automation/migrations/0005_auto_20200922_1344.py (+33 -0)
📝 api/tacticalrmm/automation/models.py (+11 -0)
➕ api/tacticalrmm/autotasks/migrations/0006_auto_20200922_1344.py (+33 -0)
📝 api/tacticalrmm/autotasks/models.py (+11 -0)
➕ api/tacticalrmm/checks/migrations/0010_auto_20200922_1344.py (+33 -0)
📝 api/tacticalrmm/checks/models.py (+11 -0)
📝 api/tacticalrmm/checks/views.py (+0 -1)
➕ api/tacticalrmm/clients/migrations/0005_auto_20200922_1344.py (+53 -0)
📝 api/tacticalrmm/clients/models.py (+22 -0)
📝 api/tacticalrmm/core/management/commands/initial_mesh_setup.py (+1 -0)

...and 33 more files

📄 Description

added created_by and modified_by fields to models that need to be audited
added a middleware that does most of the audit entries. The mesh, cmd, and script audit entries are written in the view
added item in File menu that opens the audit manager
added basic search capabilities

The only thing that is broken is the django admin page. GET requests work, but if you try and delete, or edit any of the info there is an error message. The middleware is messing with it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/amidaware/tacticalrmm/pull/115 **Author:** [@sadnub](https://github.com/sadnub) **Created:** 9/23/2020 **Status:** ✅ Merged **Merged:** 9/24/2020 **Merged by:** [@wh1te909](https://github.com/wh1te909) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (10+) - [`86bfcb7`](https://github.com/amidaware/tacticalrmm/commit/86bfcb778f8ff8fcd01de3b48ff000c46535a503) docker dev and test changes - [`fe8fb74`](https://github.com/amidaware/tacticalrmm/commit/fe8fb74fe0d9383a7f342dcae2e6e8741c0866f2) totp setup rework - [`2b2cb85`](https://github.com/amidaware/tacticalrmm/commit/2b2cb85e9820e2b61c3cd98651e08a45b334fc79) core model changes - [`d17f5df`](https://github.com/amidaware/tacticalrmm/commit/d17f5df07e69fecf7074836d67608ed629f9b20d) WIP added audit logging support - [`7030c18`](https://github.com/amidaware/tacticalrmm/commit/7030c18778043aefd0755d43d7c02393df6ecc32) fix duplicate audit log entries - [`e974845`](https://github.com/amidaware/tacticalrmm/commit/e97484529ef77f6f5699e59146e1bf863b4de314) merge migration conflict - [`5dd73e7`](https://github.com/amidaware/tacticalrmm/commit/5dd73e7ebb0dc119d18c4addb49d82ecd4ef4eae) fix tests - [`f2516fe`](https://github.com/amidaware/tacticalrmm/commit/f2516fec290251a714a7a30a7ed0eb9f5039f344) fixed administration page and generated a unique signal uid per request - [`2bd6d66`](https://github.com/amidaware/tacticalrmm/commit/2bd6d66ec738377cdbb01d950d7d91e45995b0ac) fixed named parameter bug - [`88fea13`](https://github.com/amidaware/tacticalrmm/commit/88fea13a4e194e063096b0931de38f9b7a1f6d2b) added auditing to user successful and failed attempts. Set audit log timezone to the default in core settings ### 📊 Changes **53 files changed** (+1354 additions, -288 deletions) <details> <summary>View changed files</summary> ➕ `api/tacticalrmm/accounts/migrations/0003_auto_20200922_1344.py` (+33 -0) 📝 `api/tacticalrmm/accounts/models.py` (+11 -0) 📝 `api/tacticalrmm/accounts/views.py` (+16 -6) ➕ `api/tacticalrmm/agents/migrations/0015_auto_20200922_1344.py` (+33 -0) ➕ `api/tacticalrmm/agents/migrations/0016_merge_20200923_0225.py` (+14 -0) 📝 `api/tacticalrmm/agents/models.py` (+13 -0) 📝 `api/tacticalrmm/agents/urls.py` (+1 -0) 📝 `api/tacticalrmm/agents/views.py` (+37 -1) 📝 `api/tacticalrmm/api/urls.py` (+0 -1) 📝 `api/tacticalrmm/api/views.py` (+0 -24) ➕ `api/tacticalrmm/automation/migrations/0005_auto_20200922_1344.py` (+33 -0) 📝 `api/tacticalrmm/automation/models.py` (+11 -0) ➕ `api/tacticalrmm/autotasks/migrations/0006_auto_20200922_1344.py` (+33 -0) 📝 `api/tacticalrmm/autotasks/models.py` (+11 -0) ➕ `api/tacticalrmm/checks/migrations/0010_auto_20200922_1344.py` (+33 -0) 📝 `api/tacticalrmm/checks/models.py` (+11 -0) 📝 `api/tacticalrmm/checks/views.py` (+0 -1) ➕ `api/tacticalrmm/clients/migrations/0005_auto_20200922_1344.py` (+53 -0) 📝 `api/tacticalrmm/clients/models.py` (+22 -0) 📝 `api/tacticalrmm/core/management/commands/initial_mesh_setup.py` (+1 -0) _...and 33 more files_ </details> ### 📄 Description - added created_by and modified_by fields to models that need to be audited - added a middleware that does most of the audit entries. The mesh, cmd, and script audit entries are written in the view - added item in File menu that opens the audit manager - added basic search capabilities The only thing that is broken is the django admin page. GET requests work, but if you try and delete, or edit any of the info there is an error message. The middleware is messing with it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>