mirror of
https://github.com/amidaware/tacticalrmm.git
synced 2026-04-26 15:05:57 +03:00
[GH-ISSUE #1637] Wrong SSL certificate used in information blob #1024
Labels
No labels
In Process
bug
bug
dev-triage
documentation
duplicate
enhancement
fixed
good first issue
help wanted
integration
invalid
pull-request
question
requires agent update
security
ui tweak
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/tacticalrmm#1024
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @elia-blue on GitHub (Sep 21, 2023).
Original GitHub issue: https://github.com/amidaware/tacticalrmm/issues/1637
Server Info (please complete the following information):
Installation Method:
Agent Info (please complete the following information): not applicable
Describe the bug
The SSL certificate warning in the UI uses the wrong certificate for getting its information.
To Reproduce
Steps to reproduce the behavior:
rmm.example.com-0001for NGINXlocal_settings.pyExpected behavior
The SSL certificate warning shows the correct expiration date.
Additional context
The problem lies (I think) in the
get_certs()ordays_until_cert_expires()inapi/tacticalrmm/tacticalrmm/helpers.py. I don't know why, but this function seems to ignore the settings / suffix fromlocal_settings.py. I fixed the problem on my side by renamimg the cert tormm.example.com, now everything works as expected, but this behaviour should still be looked into I think.Also, thank you guys for your great software :)
@wh1te909 commented on GitHub (Sep 21, 2023):
trmm needs either a wildcard cert, or a cert for api.example.com with 2 SANs for rmm.example.com and mesh.example.com. If you are using the letsencrypt wildcard created by the install script then there is no additional settings changes needed.
If you are using your own wildcard, or the SAN method, as stated in the docs here, then you must let TRMM know the location of your fullchain and privkey otherwise trmm has no idea that you are doing custom certs (like you are now). So follow the docs linked above and then it will show the correct dates.