[PR #527] [MERGED] Fix return object formatting for multi-market searches #925

New issue

Closed

opened 2026-02-28 00:02:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:02:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/spotipy-dev/spotipy/pull/527
Author: @nleroy917
Created: 7/3/2020
Status: ✅ Merged
Merged: 7/7/2020
Merged by: @stephanebruckert

Base: master ← Head: market_search_2

📝 Commits (7)

2df9598 resolve return object formatting issues referened in #526
e07bc2c resolve comments from @ritiek
29fdee0 create separate method to search multiple markets
68a3b8a Use old description again
722c9e9 market -> markets + fix test
4b87dfd pep8
6591666 Use break

📊 Changes

2 files changed (+94 additions, -71 deletions)

View changed files

📝 spotipy/client.py (+52 -39)
📝 tests/integration/test_non_user_endpoints.py (+42 -32)

📄 Description

I implemented the changes we discussed in #526. Now, the return object will be a dictionary with keys corresponding to the markets specified in the search with the response from Spotify stored in those keys. I also updated all of my unit tests to reflect these changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/spotipy-dev/spotipy/pull/527 **Author:** [@nleroy917](https://github.com/nleroy917) **Created:** 7/3/2020 **Status:** ✅ Merged **Merged:** 7/7/2020 **Merged by:** [@stephanebruckert](https://github.com/stephanebruckert) **Base:** `master` ← **Head:** `market_search_2` --- ### 📝 Commits (7) - [`2df9598`](https://github.com/spotipy-dev/spotipy/commit/2df9598b939605f7032d99198835456a6e5fcbc5) resolve return object formatting issues referened in #526 - [`e07bc2c`](https://github.com/spotipy-dev/spotipy/commit/e07bc2c47f47965d02e2c87912e76d89c74c1bd7) resolve comments from @ritiek - [`29fdee0`](https://github.com/spotipy-dev/spotipy/commit/29fdee0b1f1d1b84687bf6fa4cda86dee160bb30) create separate method to search multiple markets - [`68a3b8a`](https://github.com/spotipy-dev/spotipy/commit/68a3b8a196872938b81edc643cc38cb934f6b7d4) Use old description again - [`722c9e9`](https://github.com/spotipy-dev/spotipy/commit/722c9e943203494daca8b1d22a9ab89a88e9a75f) market -> markets + fix test - [`4b87dfd`](https://github.com/spotipy-dev/spotipy/commit/4b87dfdd14eb7d7936e52d8b2ab4a2ba98b6f84f) pep8 - [`6591666`](https://github.com/spotipy-dev/spotipy/commit/65916662214e438fdb53352cf16b4dd3fbf4ad07) Use break ### 📊 Changes **2 files changed** (+94 additions, -71 deletions) <details> <summary>View changed files</summary> 📝 `spotipy/client.py` (+52 -39) 📝 `tests/integration/test_non_user_endpoints.py` (+42 -32) </details> ### 📄 Description I implemented the changes we discussed in #526. Now, the return object will be a dictionary with keys corresponding to the markets specified in the search with the response from Spotify stored in those keys. I also updated all of my unit tests to reflect these changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>