mirror of
https://github.com/Rigellute/spotify-tui.git
synced 2026-04-26 08:05:57 +03:00
[PR #650] [MERGED] Implement Podcasts Library page #953
Labels
No labels
bug
enhancement
good first issue
help wanted
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-tui#953
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/Rigellute/spotify-tui/pull/650
Author: @LeonGr
Created: 11/5/2020
Status: ✅ Merged
Merged: 1/6/2021
Merged by: @Rigellute
Base:
master← Head:Podcasts📝 Commits (10+)
b7b4809Implement Podcasts Library page3055656Fix formatting issues6fb3a99Implement Podcast functionalities search resultsd31e3ebCommentc1dac38Handle left, down events for ActiveBlock EpisodeTable, Podcasts when no block is selected24422cbMerge remote-tracking branch 'upstream/master' into Podcastsd7daf24Use 'liked' icon from user config for followed podcast search resultsb5fb184Remove draw_not_impemented yet (no longer used)f9060aaUse 'get' for retrieving a show by index from search resultsf3ef9e9Merge remote-tracking branch 'upstream/master' into Podcasts📊 Changes
7 files changed (+280 additions, -45 deletions)
View changed files
📝
src/app.rs(+70 -6)📝
src/handlers/empty.rs(+4 -0)📝
src/handlers/library.rs(+1 -0)📝
src/handlers/podcasts.rs(+50 -2)📝
src/handlers/search_results.rs(+2 -4)📝
src/network.rs(+91 -0)📝
src/ui/mod.rs(+62 -33)📄 Description
Implemented:
Functions related to podcasts that are not yet implemented:
Showing heart next to followed podcasts in search resultsAbility do follow/unfollow from search resultsPossible additions:
I'm willing to work on these other functionalities too but I thought it would be good to get feedback for what I have already done.
And I was wondering if it was okay to add a
selected_show_idfield toApp, because to implement following/unfollowing from the episode table we need the viewed show's id. Another way would be callingget_an_episodefrom rspotify to get theFullEpisodeinstead ofSimplifiedEpisodeof which the former includes a reference to the show but this might create unnecessary overhead.EDIT:
Hearts and follow/unfollow now works in podcasts search results.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.