[PR #650] [MERGED] Implement Podcasts Library page #953

Closed
opened 2026-02-28 14:53:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/650
Author: @LeonGr
Created: 11/5/2020
Status: Merged
Merged: 1/6/2021
Merged by: @Rigellute

Base: masterHead: Podcasts


📝 Commits (10+)

  • b7b4809 Implement Podcasts Library page
  • 3055656 Fix formatting issues
  • 6fb3a99 Implement Podcast functionalities search results
  • d31e3eb Comment
  • c1dac38 Handle left, down events for ActiveBlock EpisodeTable, Podcasts when no block is selected
  • 24422cb Merge remote-tracking branch 'upstream/master' into Podcasts
  • d7daf24 Use 'liked' icon from user config for followed podcast search results
  • b5fb184 Remove draw_not_impemented yet (no longer used)
  • f9060aa Use 'get' for retrieving a show by index from search results
  • f3ef9e9 Merge remote-tracking branch 'upstream/master' into Podcasts

📊 Changes

7 files changed (+280 additions, -45 deletions)

View changed files

📝 src/app.rs (+70 -6)
📝 src/handlers/empty.rs (+4 -0)
📝 src/handlers/library.rs (+1 -0)
📝 src/handlers/podcasts.rs (+50 -2)
📝 src/handlers/search_results.rs (+2 -4)
📝 src/network.rs (+91 -0)
📝 src/ui/mod.rs (+62 -33)

📄 Description

Implemented:

  • Podcasts page shows list of user's saved podcasts (columns: name, publisher(s))
  • Pressing "Enter" on podcast goes to episode table
  • Pressing "D" unsaves selected podcast

Functions related to podcasts that are not yet implemented:

  • Showing heart next to followed podcasts in search results
  • Ability do follow/unfollow from search results
  • Ability to follow/unfollow from episode table

Possible additions:

  • Add name of podcast to episode table

I'm willing to work on these other functionalities too but I thought it would be good to get feedback for what I have already done.
And I was wondering if it was okay to add a selected_show_id field to App, because to implement following/unfollowing from the episode table we need the viewed show's id. Another way would be calling get_an_episode from rspotify to get the FullEpisode instead of SimplifiedEpisode of which the former includes a reference to the show but this might create unnecessary overhead.

EDIT:
Hearts and follow/unfollow now works in podcasts search results.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/650 **Author:** [@LeonGr](https://github.com/LeonGr) **Created:** 11/5/2020 **Status:** ✅ Merged **Merged:** 1/6/2021 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `Podcasts` --- ### 📝 Commits (10+) - [`b7b4809`](https://github.com/Rigellute/spotify-tui/commit/b7b480922f17caeba62e9d12904d5f70f6d33423) Implement Podcasts Library page - [`3055656`](https://github.com/Rigellute/spotify-tui/commit/305565689ce91b9b76fc3ec7cfcb725975687e9c) Fix formatting issues - [`6fb3a99`](https://github.com/Rigellute/spotify-tui/commit/6fb3a99a78e4368c48f1826b6367d1e1dcf19512) Implement Podcast functionalities search results - [`d31e3eb`](https://github.com/Rigellute/spotify-tui/commit/d31e3eb37accd83c35be78a708ab1f91af1ded9e) Comment - [`c1dac38`](https://github.com/Rigellute/spotify-tui/commit/c1dac380ed9b8f101c89dcc6e7dda70579752e69) Handle left, down events for ActiveBlock EpisodeTable, Podcasts when no block is selected - [`24422cb`](https://github.com/Rigellute/spotify-tui/commit/24422cb71fc66de628c8395160a96265469057e8) Merge remote-tracking branch 'upstream/master' into Podcasts - [`d7daf24`](https://github.com/Rigellute/spotify-tui/commit/d7daf2491391667c7998e008f4b87cff6799cf40) Use 'liked' icon from user config for followed podcast search results - [`b5fb184`](https://github.com/Rigellute/spotify-tui/commit/b5fb184a701a423427faa72ed18fcba2c2417a81) Remove draw_not_impemented yet (no longer used) - [`f9060aa`](https://github.com/Rigellute/spotify-tui/commit/f9060aa80eeb10f613ca2c9b0e518da8506cbb76) Use 'get' for retrieving a show by index from search results - [`f3ef9e9`](https://github.com/Rigellute/spotify-tui/commit/f3ef9e9c7f4c5eabe4e2419108b45fa31ad65652) Merge remote-tracking branch 'upstream/master' into Podcasts ### 📊 Changes **7 files changed** (+280 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `src/app.rs` (+70 -6) 📝 `src/handlers/empty.rs` (+4 -0) 📝 `src/handlers/library.rs` (+1 -0) 📝 `src/handlers/podcasts.rs` (+50 -2) 📝 `src/handlers/search_results.rs` (+2 -4) 📝 `src/network.rs` (+91 -0) 📝 `src/ui/mod.rs` (+62 -33) </details> ### 📄 Description Implemented: - Podcasts page shows list of user's saved podcasts (columns: name, publisher(s)) - Pressing "Enter" on podcast goes to episode table - Pressing "D" unsaves selected podcast Functions related to podcasts that are not yet implemented: - ~~Showing heart next to followed podcasts in search results~~ - ~~Ability do follow/unfollow from search results~~ - Ability to follow/unfollow from episode table Possible additions: - Add name of podcast to episode table I'm willing to work on these other functionalities too but I thought it would be good to get feedback for what I have already done. And I was wondering if it was okay to add a `selected_show_id` field to `App`, because to implement following/unfollowing from the episode table we need the viewed show's id. Another way would be calling `get_an_episode` from rspotify to get the `FullEpisode` instead of `SimplifiedEpisode` of which the former includes a reference to the show but this might create unnecessary overhead. EDIT: Hearts and follow/unfollow now works in podcasts search results. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:53:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#953
No description provided.