[PR #170] [MERGED] Adjust min/max volume values #650

Closed
opened 2026-02-28 14:50:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/Rigellute/spotify-tui/pull/170
Author: @gpawlik
Created: 11/26/2019
Status: Merged
Merged: 11/27/2019
Merged by: @Rigellute

Base: masterHead: clamp-volume


📝 Commits (1)

📊 Changes

1 file changed (+10 additions, -6 deletions)

View changed files

📝 src/app.rs (+10 -6)

📄 Description

Description of the issue

Currently if the initial volume is not of full tens (eg. 42) then the min and max values are respectively 2 and 92.

Solution to the issue

Limit the volume values correctly on 0 and 100.

Before/After screenshots 📷

Before After
v2 v1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Rigellute/spotify-tui/pull/170 **Author:** [@gpawlik](https://github.com/gpawlik) **Created:** 11/26/2019 **Status:** ✅ Merged **Merged:** 11/27/2019 **Merged by:** [@Rigellute](https://github.com/Rigellute) **Base:** `master` ← **Head:** `clamp-volume` --- ### 📝 Commits (1) - [`790e839`](https://github.com/Rigellute/spotify-tui/commit/790e83912bcf1587672d273960d525affd6f1873) Clamp volume values ### 📊 Changes **1 file changed** (+10 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/app.rs` (+10 -6) </details> ### 📄 Description ### Description of the issue Currently if the initial volume is not of full tens (eg. `42`) then the min and max values are respectively `2` and `92`. ### Solution to the issue Limit the volume values correctly on `0` and `100`. ### Before/After screenshots 📷 | Before | After | | -------------------- | ------------------- | | ![v2](https://user-images.githubusercontent.com/6296883/69675197-0009c300-1096-11ea-953c-f6114aa1b196.gif) | ![v1](https://user-images.githubusercontent.com/6296883/69675211-0c8e1b80-1096-11ea-84d4-9c09c9a46f8d.gif) | --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 14:50:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-tui#650
No description provided.