starred/spotify-tui

Fork 0

mirror of https://github.com/Rigellute/spotify-tui.git synced 2026-04-26 16:15:55 +03:00

[GH-ISSUE #18] Saving tracks with `s` doesn't appear to work #16

New issue

Closed

opened 2026-02-28 14:46:23 +03:00 by kerem · 8 comments

kerem commented

2026-02-28 14:46:23 +03:00

Owner

Originally created by @alichtman on GitHub (Oct 8, 2019).
Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/18

$ spt --version
spotify-tui 0.4.0

Originally created by @alichtman on GitHub (Oct 8, 2019). Original GitHub issue: https://github.com/Rigellute/spotify-tui/issues/18 ``` $ spt --version spotify-tui 0.4.0 ```

kerem closed this issue

2026-02-28 14:46:23 +03:00

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@wrenby commented on GitHub (Oct 8, 2019):

Right now the keybind is written to save hovered songs, not the currently playing song, and only in the recently-played list and in album listings. That seems to be intentional and functional, but it's not very user-friendly imo.

With a preface that I am tired and likely have not thought this through all the way, my pitch is the now-playing bar becomes its own hoverable element. The keybind is used to save the current song when it's hovered. Making it selectable could also provide a reasonably cohesive solution to #16 . Since the now-playing bar takes the entire width of the terminal, left and right arrows could be specialized to scrub when it's selected, ~~with Ctrl+left/right and Ctrl+up/down used globally for skipping and volume, respectively.~~ Apparently Ctrl+arrow keys are not supported in termion...

@wrenby commented on GitHub (Oct 8, 2019): Right now the keybind is written to save hovered songs, not the currently playing song, and only in the recently-played list and in album listings. That seems to be intentional and functional, but it's not very user-friendly imo. With a preface that I am tired and likely have not thought this through all the way, my pitch is the now-playing bar becomes its own hoverable element. The keybind is used to save the current song when it's hovered. Making it selectable could also provide a reasonably cohesive solution to #16 . Since the now-playing bar takes the entire width of the terminal, left and right arrows could be specialized to scrub when it's selected, ~~with Ctrl+left/right and Ctrl+up/down used globally for skipping and volume, respectively.~~ Apparently Ctrl+arrow keys are [not supported in termion](https://gitlab.redox-os.org/redox-os/termion/issues/46)...

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@Rigellute commented on GitHub (Oct 8, 2019):

Thanks for this.

As @baxtea says, I've only implemented saving a track within the Recently Played view and with the album view.

Not only do I need to add this to the other views, but also implement removing saved tracks and showing that track is liked/saved.

I like the idea of making the playbar hoverable, with its own event handlers for saving the currently playing track, viewing track info etc.

@Rigellute commented on GitHub (Oct 8, 2019): Thanks for this. As @baxtea says, I've only implemented saving a track within the Recently Played view and with the album view. Not only do I need to add this to the other views, but also implement removing saved tracks and showing that track is liked/saved. I like the idea of making the playbar hoverable, with its own event handlers for saving the currently playing track, viewing track info etc.

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@Rigellute commented on GitHub (Oct 19, 2019):

PR making the the playbar hoverable https://github.com/Rigellute/spotify-tui/pull/80

@Rigellute commented on GitHub (Oct 19, 2019): PR making the the playbar hoverable https://github.com/Rigellute/spotify-tui/pull/80

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@Rigellute commented on GitHub (Nov 26, 2019):

Saving tracks is implemented in every view now. And you can save the currently playing track by hovering on the playbar and pressing s

@Rigellute commented on GitHub (Nov 26, 2019): Saving tracks is implemented in every view now. And you can save the currently playing track by hovering on the playbar and pressing `s`

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@stigok commented on GitHub (Mar 26, 2020):

For me this is toggling shuffle.

@stigok commented on GitHub (Mar 26, 2020): For me this is toggling shuffle.

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@stigok commented on GitHub (Mar 26, 2020):

Now it worked! I had bound it to shuffle in my config.yml. Sorry! Thanks for a great app :)

@stigok commented on GitHub (Mar 26, 2020): Now it worked! I had bound it to shuffle in my `config.yml`. Sorry! Thanks for a great app :)

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@blueforesticarus commented on GitHub (Apr 8, 2020):

saving works for me in the song view for regular album/playlists , but not when I have discover weekly open, then "s" doesn't do anything

@blueforesticarus commented on GitHub (Apr 8, 2020): saving works for me in the song view for regular album/playlists , but not when I have discover weekly open, then "s" doesn't do anything

kerem commented

2026-02-28 14:46:24 +03:00

Author

Owner

@ericonr commented on GitHub (Apr 16, 2020):

@blueForestIcarus

As baxtea says, I've only implemented saving a track within the Recently Played view and with the album view.
Not only do I need to add this to the other views, but also implement removing saved tracks and showing that track is liked/saved.

You can probably open a new issue for it, to track the implementation.

@ericonr commented on GitHub (Apr 16, 2020): @blueForestIcarus > As baxtea says, I've only implemented saving a track within the Recently Played view and with the album view. > Not only do I need to add this to the other views, but also implement removing saved tracks and showing that track is liked/saved. You can probably open a new issue for it, to track the implementation.