[PR #678] [CLOSED] Fixing bug when performing an action on an album #838

New issue

Closed

opened 2026-03-03 00:01:03 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 00:01:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/678
Author: @JohnOberhauser
Created: 2/7/2025
Status: ❌ Closed

Base: master ← Head: sort-fix

📝 Commits (1)

6968e13 Fixing bug when doing an action on an album when albums are sorted by types instead of date

📊 Changes

3 files changed (+33 additions, -22 deletions)

View changed files

📝 spotify_player/src/event/window.rs (+12 -7)
📝 spotify_player/src/ui/page.rs (+3 -15)
📝 spotify_player/src/utils.rs (+18 -0)

📄 Description

Fixing a bug where performing an action on an album can apply that action to the wrong album.

Introduced in my last PR https://github.com/aome510/spotify-player/pull/654

My original PR sorted the UI, but I didn't realize actions on albums happen based on the selected index (not the selected album). So I'm adding album sorting to the album event window as well.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/678 **Author:** [@JohnOberhauser](https://github.com/JohnOberhauser) **Created:** 2/7/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `sort-fix` --- ### 📝 Commits (1) - [`6968e13`](https://github.com/aome510/spotify-player/commit/6968e131844df038448d63220db5152bb19f9eb7) Fixing bug when doing an action on an album when albums are sorted by types instead of date ### 📊 Changes **3 files changed** (+33 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/window.rs` (+12 -7) 📝 `spotify_player/src/ui/page.rs` (+3 -15) 📝 `spotify_player/src/utils.rs` (+18 -0) </details> ### 📄 Description Fixing a bug where performing an action on an album can apply that action to the wrong album. Introduced in my last PR https://github.com/aome510/spotify-player/pull/654 My original PR sorted the UI, but I didn't realize actions on albums happen based on the selected _index_ (not the selected album). So I'm adding album sorting to the album event window as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>