[PR #228] [CLOSED] Add block-image feature which forces rendering images using half blocks #678

Closed
opened 2026-03-02 23:49:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/228
Author: @m-torhan
Created: 8/1/2023
Status: Closed

Base: masterHead: add-block-image-feature


📝 Commits (1)

  • caf5d4f Add block-image feature which forces rendering images using half blocks

📊 Changes

4 files changed (+24 additions, -11 deletions)

View changed files

📝 README.md (+3 -0)
📝 spotify_player/Cargo.toml (+1 -0)
📝 spotify_player/src/main.rs (+1 -1)
📝 spotify_player/src/ui/playback.rs (+19 -10)

📄 Description

spotify-player with enabled image cannot run in zellij in kitty - it hangs on viuer::get_kitty_support(). To enable running spotify-player in zellij I added feature block-image which forces rendering images using half-blocks.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/228 **Author:** [@m-torhan](https://github.com/m-torhan) **Created:** 8/1/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `add-block-image-feature` --- ### 📝 Commits (1) - [`caf5d4f`](https://github.com/aome510/spotify-player/commit/caf5d4f1cd5258499f5f30b5485c0bfad60cbd64) Add block-image feature which forces rendering images using half blocks ### 📊 Changes **4 files changed** (+24 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -0) 📝 `spotify_player/Cargo.toml` (+1 -0) 📝 `spotify_player/src/main.rs` (+1 -1) 📝 `spotify_player/src/ui/playback.rs` (+19 -10) </details> ### 📄 Description `spotify-player` with enabled `image` cannot run in `zellij` in `kitty` - it hangs on `viuer::get_kitty_support()`. To enable running `spotify-player` in `zellij` I added feature `block-image` which forces rendering images using half-blocks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 23:49:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#678
No description provided.