[PR #386] [MERGED] Patch spotify API bugs #744

New issue

Closed

opened 2026-03-02 23:49:37 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:49:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/386
Author: @aome510
Created: 3/3/2024
Status: ✅ Merged
Merged: 3/3/2024
Merged by: @aome510

Base: master ← Head: patch-spotify-api-bugs

📝 Commits (5)

ad4638d don't send GetContext for ContextId::Tracks
8e9fa98 fix artist page not loading
b2ffd26 fix radio(recommendation) page not loading
6230f84 fix playlist page not loading for no-image playlists
cbf51ff update comments

📊 Changes

2 files changed (+110 additions, -27 deletions)

View changed files

📝 spotify_player/src/client/handlers.rs (+2 -1)
📝 spotify_player/src/client/mod.rs (+108 -26)

📄 Description

Resolves #330
Resolves #383
Resolves #384

Related upstream issues:

This PR implements patches for upstream Spotify API bugs by using client::Client::internal_call to get Spotify data instead of rspotify APIs. Using internal_call allows the app's client to avoid parsing errors when rspotify parses Spotify API responses and fixes

artist page not loading
recommendation/radio tracks page not loading
playlist page not loading for playlists with no image

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/386 **Author:** [@aome510](https://github.com/aome510) **Created:** 3/3/2024 **Status:** ✅ Merged **Merged:** 3/3/2024 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `patch-spotify-api-bugs` --- ### 📝 Commits (5) - [`ad4638d`](https://github.com/aome510/spotify-player/commit/ad4638d9bd8ee7356b8051ccc6e742e4346c1af2) don't send `GetContext` for `ContextId::Tracks` - [`8e9fa98`](https://github.com/aome510/spotify-player/commit/8e9fa98b75c013a0254a6e1c3ec2c9c530bf99d7) fix artist page not loading - [`b2ffd26`](https://github.com/aome510/spotify-player/commit/b2ffd26a7a470632410d22c8dfcb05b345a05634) fix radio(recommendation) page not loading - [`6230f84`](https://github.com/aome510/spotify-player/commit/6230f840fe7dfde10c2bb00981aada85e4141a01) fix playlist page not loading for no-image playlists - [`cbf51ff`](https://github.com/aome510/spotify-player/commit/cbf51ff454c209a3f3527d4911e649abc434ea6c) update comments ### 📊 Changes **2 files changed** (+110 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/client/handlers.rs` (+2 -1) 📝 `spotify_player/src/client/mod.rs` (+108 -26) </details> ### 📄 Description Resolves #330 Resolves #383 Resolves #384 Related upstream issues: - https://github.com/ramsayleung/rspotify/issues/452 - https://github.com/ramsayleung/rspotify/issues/459 This PR implements patches for upstream Spotify API bugs by using `client::Client::internal_call` to get Spotify data instead of `rspotify` APIs. Using `internal_call` allows the app's client to avoid parsing errors when `rspotify` parses Spotify API responses and fixes - artist page not loading - recommendation/radio tracks page not loading - playlist page not loading for playlists with no image --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>