mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #660] Ghostty album cover image #383
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#383
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @5183nischal on GitHub (Jan 13, 2025).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/660
Is your feature already implemented in the latest
master?No
Is your feature request related to a problem? Please describe.
Ghostty terminal supports kitty graphics but the album cover is not rendered using it.
Describe the solution you'd like
Use kitty graphics protocol to display album cover.
@m4r1vs commented on GitHub (Jan 16, 2025):
It is rendered for me using ghostty on x86 Linux with Wayland.. are you maybe using a multiplexer like tmux? That could interfere with spotify_player being able to detect the terminal
@m4r1vs commented on GitHub (Jan 16, 2025):
Try running spotify_player (built with the image feature ofc) using
ghostty -e spotify_playerand see if it works now :)@5183nischal commented on GitHub (Jan 16, 2025):
Hi, thank you! Yes, tmux was the issue. Is there a way to get a proper rendering inside tmux? I didn't see anything in the docs.
@m4r1vs commented on GitHub (Jan 16, 2025):
Hmm, not sure if this is an issue with this project, tmux or ghostty. Do you know if it works with tmux in kitty terminal? If so, that indicates that it should be solved in ghostty or tmux.
However, some other apps like yazi work for me in tmux with ghostty so maybe this can be fixed in here directly.
Unfortunately, I have no experience whatsoever with the kitty protocol and have no idea how to check if it is available.
However, right now I am digging through the codebase a bit so if I find a solution, I'll post it here
@m4r1vs commented on GitHub (Jan 16, 2025):
Seems to be handled by https://github.com/atanunq/viuer
@m4r1vs commented on GitHub (Jan 16, 2025):
Maybe relevant: https://github.com/atanunq/viuer/issues/67
@m4r1vs commented on GitHub (Jan 16, 2025):
github.com/atanunq/viuer@f66fa7710e/src/printer/kitty.rs (L62)@m4r1vs commented on GitHub (Jan 16, 2025):
They check for "ghostty" in the "$TERM" environment variable. Maybe set it manually for now?
@m4r1vs commented on GitHub (Jan 16, 2025):
Okay, when I do
export TERM="xterm-ghostty", spotify_player won't start..@m4r1vs commented on GitHub (Jan 16, 2025):
Same for doing it through tmux and updating "TERM_PROGRAM"
@m4r1vs commented on GitHub (Jan 16, 2025):
I wonder how yazi (and image.nvim) do it...? I have
in my tmux config but not quite sure what it does tbh
@m4r1vs commented on GitHub (Jan 16, 2025):
Just commented out these lines and yazi kitty still works lol
@m4r1vs commented on GitHub (Jan 16, 2025):
Seems like this needs to be addressed in viuer because when we set the terminal to "xterm-ghostty" within tmux,
viuer::get_kitty_support()blocks till infinity@rhodes-b commented on GitHub (Jan 19, 2025):
There is a way to allow it to work in tmux etc as well, but both the terminal and program have to support this both kitty and ghostty support the pass-through not sure if the program does
https://sw.kovidgoyal.net/kitty/graphics-protocol/#unicode-placeholders
@artem-simutin commented on GitHub (Mar 2, 2025):
+1 Have the exact same issue with Ghostty + Tmux.
Detaching from Tmux helps.
@gurdittcancode commented on GitHub (Apr 26, 2025):
@artem-simutin unrelated but can you share your ghostty theme? looks cool lol
@felixschmelzer commented on GitHub (Jun 28, 2025):
+1 it doesn’t work when using tmux. It does work in Ghost, iTerm, and Kitty, but it stops working as soon as I run it inside tmux, no matter which terminal emulator I use.
@qiUip commented on GitHub (Jul 19, 2025):
+1 Same issue. Works fine in kitty, looks like the above in kitty + tmux.
Thanks to @rhodes-b link, I think it might indeed be related to the unicode escape code - if that's the case I will try and play around with it and see if I can find a decent fix (I've never wrote any rust or used kitty's image protocol so not expecting to solve it, but it's worth a try).