mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[PR #329] [MERGED] Add custom text input widget with cursor, to use in search page #719
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#719
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/aome510/spotify-player/pull/329
Author: @micleo2
Created: 1/5/2024
Status: ✅ Merged
Merged: 1/16/2024
Merged by: @aome510
Base:
master← Head:cursor-search-input📝 Commits (4)
52125beAdd custom text input widget with cursor, to use in search page0467a03Remove unused LineInput style fields0d95ad1cleanup, simplify the implementation9657617don't return error when initializing user data📊 Changes
9 files changed (+151 additions, -46 deletions)
View changed files
📝
spotify_player/src/event/mod.rs(+2 -1)📝
spotify_player/src/event/page.rs(+13 -24)📝
spotify_player/src/main.rs(+1 -1)📝
spotify_player/src/state/data.rs(+7 -7)📝
spotify_player/src/state/mod.rs(+4 -4)📝
spotify_player/src/state/ui/page.rs(+2 -2)📝
spotify_player/src/ui/mod.rs(+1 -0)📝
spotify_player/src/ui/page.rs(+4 -7)➕
spotify_player/src/ui/single_line_input.rs(+117 -0)📄 Description
I found using the search bar to be a confusing experience without a cursor. This adds a very simple implementation. You can type, delete with backspace, and navigate with left/right arrows. This can be easily extended in the future to support some basic Emacs-style navigation: by word, end of line etc.
Short video containing usage:
https://github.com/aome510/spotify-player/assets/12721457/5a342c28-d447-4696-ac48-e3d4f0b283bc
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.