[PR #719] [MERGED] fix playlist folders sorting #1787

Closed
opened 2026-03-14 15:33:08 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/719
Author: @aNNiMON
Created: 5/11/2025
Status: Merged
Merged: 5/13/2025
Merged by: @aome510

Base: masterHead: fix-folders-sort


📝 Commits (1)

  • baf0718 fix playlist folders sorting

📊 Changes

1 file changed (+17 additions, -4 deletions)

View changed files

📝 spotify_player/src/event/page.rs (+17 -4)

📄 Description

The current library sort action doesn't take playlist folders into account, resulting in a panic in smallsort::panic_on_ord_violation. This PR fixes that.

I also added priority for folders. Because otherwise it brings the up level item to the end:

https://github.com/user-attachments/assets/eb0e99bf-7f1d-45c4-8a5c-ad58db16a3df


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/719 **Author:** [@aNNiMON](https://github.com/aNNiMON) **Created:** 5/11/2025 **Status:** ✅ Merged **Merged:** 5/13/2025 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `fix-folders-sort` --- ### 📝 Commits (1) - [`baf0718`](https://github.com/aome510/spotify-player/commit/baf0718375289247f4c55416d39786c90c593dcd) fix playlist folders sorting ### 📊 Changes **1 file changed** (+17 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `spotify_player/src/event/page.rs` (+17 -4) </details> ### 📄 Description The current library sort action doesn't take playlist folders into account, resulting in a panic in `smallsort::panic_on_ord_violation`. This PR fixes that. I also added priority for folders. Because otherwise it brings the up level item to the end: https://github.com/user-attachments/assets/eb0e99bf-7f1d-45c4-8a5c-ad58db16a3df --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:33:08 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1787
No description provided.