starred/spotify-player

Fork 0

mirror of https://github.com/aome510/spotify-player.git synced 2026-04-26 01:15:55 +03:00

[GH-ISSUE #143] `playback_window_width` should be `playback_window_height` #64

New issue

Closed

opened 2026-03-02 23:44:12 +03:00 by kerem · 4 comments

kerem commented

2026-03-02 23:44:12 +03:00

Owner

Originally created by @sewnie on GitHub (Feb 22, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/143

Describe the bug
the configuration option playback_window_width looks like it would specify the width, but it actually specifies the height

i think cuz like width is not really controlled here
and height is like how tall it is and that is what is changed in the tui

To Reproduce
uhh no

Expected behavior
its called playback_window_height

Log and backtrace
i feel sad becuase of the name, thats the log

Screenshots

Environment
no

Additional context

im sorry i cant make a pr because i dont know rust and im scared i will actidentally break the program

Originally created by @sewnie on GitHub (Feb 22, 2023). Original GitHub issue: https://github.com/aome510/spotify-player/issues/143 **Describe the bug** the configuration option `playback_window_width` looks like it would specify the width, but it actually specifies the height i think cuz like width is not really controlled here and height is like how tall it is and that is what is changed in the tui **To Reproduce** uhh no **Expected behavior** its called `playback_window_height` **Log and backtrace** i feel sad becuase of the name, thats the log **Screenshots** ![image](https://user-images.githubusercontent.com/47404953/220673782-82da9091-acb3-41c5-941b-d5f6629656b7.png) **Environment** no **Additional context** im sorry i cant make a pr because i dont know rust and im scared i will actidentally break the program

kerem

2026-03-02 23:44:12 +03:00

closed this issue
added the
bug
label

kerem commented

2026-03-02 23:44:13 +03:00

Author

Owner

@aome510 commented on GitHub (Feb 22, 2023):

Yeah, I agree it's quite confusing. It's a width as in terms of a rectangle's width (and length). I'll keep this as-is because some UI codes actually rely on this way of understanding.

im sorry i cant make a pr because i dont know rust and im scared i will actidentally break the program

Nah, it's always good to learn, especially learning Rust ;). Github should already protect from merging a non-approved PR, so no need to worry about that.

I'll close this issue for now. Feel free to re-open if you have any other questions.

@aome510 commented on GitHub (Feb 22, 2023): Yeah, I agree it's quite confusing. It's a width as in terms of a rectangle's width (and length). I'll keep this as-is because some UI codes actually rely on this way of understanding. > im sorry i cant make a pr because i dont know rust and im scared i will actidentally break the program Nah, it's always good to learn, especially learning Rust ;). Github should already protect from merging a non-approved PR, so no need to worry about that. I'll close this issue for now. Feel free to re-open if you have any other questions.

kerem commented

2026-03-02 23:44:13 +03:00

Author

Owner

@sewnie commented on GitHub (Feb 22, 2023):

I'll close this issue for now. Feel free to re-open if you have any other questions.

https://github.com/aome510/spotify-player/blob/master/examples/theme.toml doesnt contain the default theme, which does terminal colors

i have no clue what counts as a terminal color, since i wanna have my own theme rn

@sewnie commented on GitHub (Feb 22, 2023): > I'll close this issue for now. Feel free to re-open if you have any other questions. https://github.com/aome510/spotify-player/blob/master/examples/theme.toml doesnt contain the `default` theme, which does terminal colors i have no clue what counts as a terminal color, since i wanna have my own theme rn

kerem commented

2026-03-02 23:44:13 +03:00

Author

Owner

@aome510 commented on GitHub (Feb 22, 2023):

i have no clue what counts as a terminal color, since i wanna have my own theme rn

If you don't specify a field in theme.palette, it will default to use terminal's colors. In addition, you can refer to theme document

In the document,

If a field is not specified, its default value will be based on the terminal's corresponding color. If specified, a field's value must be set to be a hex representation of a RGB color. For example, background = "#1e1f29".

@aome510 commented on GitHub (Feb 22, 2023): > i have no clue what counts as a terminal color, since i wanna have my own theme rn If you don't specify a field in `theme.palette`, it will default to use terminal's colors. In addition, you can refer to [theme document](https://github.com/aome510/spotify-player/blob/master/docs/config.md#themes) In the document, > If a field is not specified, its default value will be based on the terminal's corresponding color. If specified, a field's value must be set to be a hex representation of a RGB color. For example, background = "#1e1f29".

kerem commented

2026-03-02 23:44:13 +03:00

Author

Owner

@sewnie commented on GitHub (Feb 22, 2023):

i guess using the keys from StyleColor work tho lol.

@sewnie commented on GitHub (Feb 22, 2023): i guess using the keys from `StyleColor` work tho lol.

kerem referenced this issue

2026-03-14 12:38:34 +03:00

[GH-ISSUE #64] Release Binaries #953