[GH-ISSUE #280] Lyric finder returns 18th century political pamphlet rather than correct lyrics #143

Closed
opened 2026-03-02 23:44:56 +03:00 by kerem · 2 comments
Owner

Originally created by @SebRollen on GitHub (Nov 1, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/280

Describe the bug
A clear and concise description of what the bug is.
This one is pretty funny. When I navigate to the lyric page for the track "Love Will Tear Us Apart - 2010 Remaster" by Joy Division, the lyric page displays the full text of the 1790 political pamphlet Reflections on the Revolution in France by Edmund Burke rather than the correct lyrics.

I have since gotten quite a few other random misses, including a chapter out of Joyce's "Ulysses" and Simone de Beauvoir's "The Second Sex"

The unifying characteristics between these three seem to be the presence of a hyphen in the name of the track, and some version of "Remaster" in the track name.

To Reproduce
Steps to reproduce the behavior.

Build spotify-player with the lyric-finder feature, start playback for "Love Will Tear Us Apart - 2010 Remaster" by Joy Division and go to the lyric page using "g L".

Expected behavior
A clear and concise description of what you expected to happen.
Should return the correct lyrics from Genius.

Log and backtrace
Reference log and backtrace, which are usually located in $HOME/.cache/spotify-player/, of a run reproducing the bug.

Nothing particularly noteworthy in the logs, the lyric-finder seems to think it found the correct lyrics:

2023-11-01T19:14:12.913150Z  INFO client_request{request=GetLyric { track: "Kangaroo - Remastered", artists: "This Mortal Coil" }}: spotify_player::client: successfully handled the client request, took: 1173ms

Screenshots
If applicable, add screenshots to help explain your problem.
Screen Shot 2023-11-01 at 2 55 15 PM
Screen Shot 2023-11-01 at 3 12 14 PM
Screen Shot 2023-11-01 at 3 14 16 PM

Environment

  • OS: iOS
  • Application version: 0.15.2
  • Application features: lyric-finder

Additional context
I tried replicating the behavior by passing in the track and artist directly to the lyric-finder example binary, but when doing that, it actually returned the correct lyrics.

This is the funniest software bug I have run into, and I'm totally fine with it not being fixed for the easter-egg potential haha.

Originally created by @SebRollen on GitHub (Nov 1, 2023). Original GitHub issue: https://github.com/aome510/spotify-player/issues/280 **Describe the bug** A clear and concise description of what the bug is. This one is pretty funny. When I navigate to the lyric page for the track "Love Will Tear Us Apart - 2010 Remaster" by Joy Division, the lyric page displays the full text of the 1790 political pamphlet [Reflections on the Revolution in France](https://en.wikipedia.org/wiki/Reflections_on_the_Revolution_in_France) by Edmund Burke rather than the correct lyrics. I have since gotten quite a few other random misses, including a chapter out of Joyce's "Ulysses" and Simone de Beauvoir's "The Second Sex" The unifying characteristics between these three seem to be the presence of a hyphen in the name of the track, and some version of "Remaster" in the track name. **To Reproduce** Steps to reproduce the behavior. Build spotify-player with the lyric-finder feature, start playback for "Love Will Tear Us Apart - 2010 Remaster" by Joy Division and go to the lyric page using "g L". **Expected behavior** A clear and concise description of what you expected to happen. Should return the correct lyrics from Genius. **Log and backtrace** Reference log and backtrace, which are usually located in `$HOME/.cache/spotify-player/`, of a run reproducing the bug. Nothing particularly noteworthy in the logs, the lyric-finder seems to think it found the correct lyrics: ``` 2023-11-01T19:14:12.913150Z INFO client_request{request=GetLyric { track: "Kangaroo - Remastered", artists: "This Mortal Coil" }}: spotify_player::client: successfully handled the client request, took: 1173ms ``` **Screenshots** If applicable, add screenshots to help explain your problem. ![Screen Shot 2023-11-01 at 2 55 15 PM](https://github.com/aome510/spotify-player/assets/38324289/7ddfaac0-70ad-4677-b4c2-b6bf0e05b2b8) ![Screen Shot 2023-11-01 at 3 12 14 PM](https://github.com/aome510/spotify-player/assets/38324289/1ee83881-ad33-4180-81fe-781881745d0b) ![Screen Shot 2023-11-01 at 3 14 16 PM](https://github.com/aome510/spotify-player/assets/38324289/edf3c85e-66e8-469d-b154-30636a433308) **Environment** - OS: iOS - Application version: 0.15.2 - Application features: lyric-finder **Additional context** I tried replicating the behavior by passing in the track and artist directly to the `lyric-finder` example binary, but when doing that, it actually returned the correct lyrics. This is the funniest software bug I have run into, and I'm totally fine with it not being fixed for the easter-egg potential haha.
kerem 2026-03-02 23:44:56 +03:00
  • closed this issue
  • added the
    bug
    label
Author
Owner

@aome510 commented on GitHub (Nov 1, 2023):

This one is pretty funny. When I navigate to the lyric page for the track "Love Will Tear Us Apart - 2010 Remaster" by Joy Division, the lyric page displays the full text of the 1790 political pamphlet Reflections on the Revolution in France by Edmund Burke rather than the correct lyrics.

Haha, nice catch.

There is a commit to remove remastered and remix info when query the lyric (github.com/aome510/spotify-player@bd1659a70a). Can you try again with the latest main to see if it fixes the issue?

<!-- gh-comment-id:1789793393 --> @aome510 commented on GitHub (Nov 1, 2023): > This one is pretty funny. When I navigate to the lyric page for the track "Love Will Tear Us Apart - 2010 Remaster" by Joy Division, the lyric page displays the full text of the 1790 political pamphlet [Reflections on the Revolution in France](https://en.wikipedia.org/wiki/Reflections_on_the_Revolution_in_France) by Edmund Burke rather than the correct lyrics. Haha, nice catch. There is a commit to remove remastered and remix info when query the lyric (https://github.com/aome510/spotify-player/commit/bd1659a70ace449e90efbd25a543d17ad9df02f6). Can you try again with the latest `main` to see if it fixes the issue?
Author
Owner

@SebRollen commented on GitHub (Nov 2, 2023):

Missed that this had already been fixed, thanks for the quick response!

<!-- gh-comment-id:1789881392 --> @SebRollen commented on GitHub (Nov 2, 2023): Missed that this had already been fixed, thanks for the quick response!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#143
No description provided.