mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 01:15:55 +03:00
[GH-ISSUE #280] Lyric finder returns 18th century political pamphlet rather than correct lyrics #143
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#143
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SebRollen on GitHub (Nov 1, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/280
Describe the bug
A clear and concise description of what the bug is.
This one is pretty funny. When I navigate to the lyric page for the track "Love Will Tear Us Apart - 2010 Remaster" by Joy Division, the lyric page displays the full text of the 1790 political pamphlet Reflections on the Revolution in France by Edmund Burke rather than the correct lyrics.
I have since gotten quite a few other random misses, including a chapter out of Joyce's "Ulysses" and Simone de Beauvoir's "The Second Sex"
The unifying characteristics between these three seem to be the presence of a hyphen in the name of the track, and some version of "Remaster" in the track name.
To Reproduce
Steps to reproduce the behavior.
Build spotify-player with the lyric-finder feature, start playback for "Love Will Tear Us Apart - 2010 Remaster" by Joy Division and go to the lyric page using "g L".
Expected behavior
A clear and concise description of what you expected to happen.
Should return the correct lyrics from Genius.
Log and backtrace
Reference log and backtrace, which are usually located in
$HOME/.cache/spotify-player/, of a run reproducing the bug.Nothing particularly noteworthy in the logs, the lyric-finder seems to think it found the correct lyrics:
Screenshots



If applicable, add screenshots to help explain your problem.
Environment
Additional context
I tried replicating the behavior by passing in the track and artist directly to the
lyric-finderexample binary, but when doing that, it actually returned the correct lyrics.This is the funniest software bug I have run into, and I'm totally fine with it not being fixed for the easter-egg potential haha.
@aome510 commented on GitHub (Nov 1, 2023):
Haha, nice catch.
There is a commit to remove remastered and remix info when query the lyric (
github.com/aome510/spotify-player@bd1659a70a). Can you try again with the latestmainto see if it fixes the issue?@SebRollen commented on GitHub (Nov 2, 2023):
Missed that this had already been fixed, thanks for the quick response!
playback_window_widthshould beplayback_window_height#1000