[PR #44] [MERGED] Media control follow-up improvements #597

New issue

Closed

opened 2026-03-02 23:48:58 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:48:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/44
Author: @aome510
Created: 5/28/2022
Status: ✅ Merged
Merged: 5/30/2022
Merged by: @aome510

Base: master ← Head: media-control-improvement

📝 Commits (10+)

e21cec5 add enable_media_control config option
3c5613e rename ReconnectIntegratedClient to RestartIntegratedClient
f209b22 correctly set platform config
d155519 add map_join util function
0c69f44 only update metadata if track is changed
ff144f5 only update media playback if changed for linux
d1af145 fix compile error for linux target
f57bb2d fix clippy for linux target
1ba4cb9 update CI: add multiple OSes
2507ce9 update CI linux deps

📊 Changes

14 files changed (+167 additions, -104 deletions)

View changed files

📝 .github/workflows/ci.yml (+9 -4)
📝 Cargo.lock (+2 -2)
📝 README.md (+46 -24)
📝 doc/config.md (+21 -12)
📝 examples/app.toml (+1 -0)
📝 spotify_player/Cargo.toml (+1 -1)
📝 spotify_player/src/command.rs (+2 -2)
📝 spotify_player/src/config/keymap.rs (+1 -1)
📝 spotify_player/src/config/mod.rs (+13 -0)
📝 spotify_player/src/event/mod.rs (+3 -13)
📝 spotify_player/src/main.rs (+1 -1)
📝 spotify_player/src/media_control.rs (+52 -34)
📝 spotify_player/src/state/model.rs (+2 -10)
📝 spotify_player/src/utils.rs (+13 -0)

📄 Description

Changes

added enable_media_control config option
fixed media control issues when running on Linux
updated github CI to include more macOS and windows in addition to ubuntu as running OSes
updated documents
- added information about new media-control feature
- cleaned up documents, updated wordings, etc

Breaking changes

renamed ReconnectIntegratedClient to RestartIntegratedClient

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/44 **Author:** [@aome510](https://github.com/aome510) **Created:** 5/28/2022 **Status:** ✅ Merged **Merged:** 5/30/2022 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `media-control-improvement` --- ### 📝 Commits (10+) - [`e21cec5`](https://github.com/aome510/spotify-player/commit/e21cec5275b45479a7a548e6c79736b3344409fe) add `enable_media_control` config option - [`3c5613e`](https://github.com/aome510/spotify-player/commit/3c5613ea5f00d0c002020fc253b2f7808472d162) rename `ReconnectIntegratedClient` to `RestartIntegratedClient` - [`f209b22`](https://github.com/aome510/spotify-player/commit/f209b22cf62acdda4df6a267b8bd950cd88fa05a) correctly set platform config - [`d155519`](https://github.com/aome510/spotify-player/commit/d1555198f4da858399e01b0a255d313dc4e2fd45) add `map_join` util function - [`0c69f44`](https://github.com/aome510/spotify-player/commit/0c69f4456e95b584002d2b96586d7d1747171a54) only update metadata if track is changed - [`ff144f5`](https://github.com/aome510/spotify-player/commit/ff144f5249d13a77e90cfef47f733f45cafed05b) only update media playback if changed for linux - [`d1af145`](https://github.com/aome510/spotify-player/commit/d1af1455d8044900d4f9fcd86d31f78ed362bae0) fix compile error for linux target - [`f57bb2d`](https://github.com/aome510/spotify-player/commit/f57bb2da2e2df55949fffccee017aa3d29adbd1f) fix clippy for linux target - [`1ba4cb9`](https://github.com/aome510/spotify-player/commit/1ba4cb9c9c7ed1826839ee91ffbeb5157bfea49f) update CI: add multiple OSes - [`2507ce9`](https://github.com/aome510/spotify-player/commit/2507ce938a9d3a489bf551bbd94d13bf1e9d7f73) update CI linux deps ### 📊 Changes **14 files changed** (+167 additions, -104 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+9 -4) 📝 `Cargo.lock` (+2 -2) 📝 `README.md` (+46 -24) 📝 `doc/config.md` (+21 -12) 📝 `examples/app.toml` (+1 -0) 📝 `spotify_player/Cargo.toml` (+1 -1) 📝 `spotify_player/src/command.rs` (+2 -2) 📝 `spotify_player/src/config/keymap.rs` (+1 -1) 📝 `spotify_player/src/config/mod.rs` (+13 -0) 📝 `spotify_player/src/event/mod.rs` (+3 -13) 📝 `spotify_player/src/main.rs` (+1 -1) 📝 `spotify_player/src/media_control.rs` (+52 -34) 📝 `spotify_player/src/state/model.rs` (+2 -10) 📝 `spotify_player/src/utils.rs` (+13 -0) </details> ### 📄 Description ## Changes - added `enable_media_control` config option - fixed media control issues when running on Linux - updated github CI to include more macOS and windows in addition to ubuntu as running OSes - updated documents + added information about new `media-control` feature + cleaned up documents, updated wordings, etc ## Breaking changes - renamed `ReconnectIntegratedClient` to `RestartIntegratedClient` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>