mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 17:35:50 +03:00
[GH-ISSUE #120] playback_progress_bar option is ignored #50
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#50
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @0323pin on GitHub (Feb 5, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/120
@aome510 Sorry to bother you again :(
Describe the bug
playback_progress_bardoesn't respect configuration options set by the user.To Reproduce
Set the variable
playback_progress_barintheme.tomlto anything but the default. Start the player and watch the default values being applied to the UI progress bar.Expected behavior
The options in the config file should be honored.
Log and backtrace
Reference log, https://pastebin.com/4bn7Qcxx
Screenshots
The config file is shown in the screenshots but, if you want to look closer you can find it here
Notice in the screenshots, that if I reverse
fgandbg(screenshot 1 and 2) the UI looks exactly the same.Environment
EDIT
Actually, it doesn't respect the defaults either. The
foregroundshould be Green on defaults but, it's White.@0323pin commented on GitHub (Feb 5, 2023):
Reproduced on Void linux. Binary built with
cargo build --release --no-default-features --features alsa-backendv0.10.0
v0.11.0
@aome510 commented on GitHub (Feb 5, 2023):
Hi pin, thanks for reporting. Should be fixed by #121.
The bug was because of a typo in https://github.com/aome510/spotify-player/pull/121/commits/44a1a6f257fcfdf73765da6e293a63bf034f018d#diff-82d73b66336ce17de09822c7a042192a440ac81555460ae4b725e6b5d0cda3efL234.
@aome510 commented on GitHub (Feb 5, 2023):
If no bug is reported by eod, I can release a new minor version with the fix.
@0323pin commented on GitHub (Feb 5, 2023):
@aome510 Thanks! Just re-built from git-HEAD and it's fixed.
@aome510 commented on GitHub (Feb 6, 2023):
@0323pin released https://github.com/aome510/spotify-player/releases/tag/v0.11.1
@0323pin commented on GitHub (Feb 6, 2023):
@aome510 On my way to work right now, will update the package tonight. Thanks!
@0323pin commented on GitHub (Feb 6, 2023):
Updated and merged now.