mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #236] Theme ignored #120
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#120
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maglore9900 on GitHub (Aug 25, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/236
Describe the bug
The current documentation for using themes is incorrect, there are certain values that Spotify-Player is looking for, including capitalization, which it will complain about.
However, even after make the necessary changes so the theme is accepted, it ignores the theme values and continues to display with the default colors.
To Reproduce
create a theme, adjust colors, use RGB or Hex codes, run spotify-player -t [theme name], no display / color changes are applied
Expected behavior
theme should change
Log and backtrace
Reference log and backtrace, which are usually located in
$HOME/.cache/spotify-player/, of a run reproducing the bug.Screenshots
If applicable, add screenshots to help explain your problem.
Environment
spotify_playerAdditional context
Add any other context about the problem here.
@aome510 commented on GitHub (Aug 26, 2023):
Theme selection still works fine for me. Can you provide the corresponding theme configs? Without that, it's impossible to know the problem.
Can you elaborate on which part is incorrect or outdated?
@maglore9900 commented on GitHub (Aug 26, 2023):
Hello Aome510, certainly.
Here is an excerpt from the documentation in the configuration setting:
bright_blue bright_cyan bright_green bright_magenta bright_red bright_white bright_yellowhere is what it requests when I run spotify-player with the theme. as you see below it wants camel case
BrightBlack = "#555555" BrightRed = "#ff5555" BrightGreen = "#50fa7b" BrightYellow = "#f1fa8c" BrightBlue = "#bd93f9" BrightMagenta = "#ff79c6" BrightCyan = "#8be9fd" BrightWhite = "#ffffff"here is an config where I took the existing theme and changed the values of Red and Magenta
`themes
name = "default"
[themes.palette]
background = "#1e1f29"
foreground = "#f8f8f2"
Black = "#000000"
Red = "#d21a75"
Green = "#50fa7b"
Yellow = "#f1fa8c"
Blue = "#bd93f9"
Magenta = "#972050"
Cyan = "#8be9fd"
White = "#bbbbbb"
BrightBlack = "#555555"
BrightRed = "#ff5555"
BrightGreen = "#50fa7b"
BrightYellow = "#f1fa8c"
BrightBlue = "#bd93f9"
BrightMagenta = "#ff79c6"
BrightCyan = "#8be9fd"
BrightWhite = "#ffffff"
[themes.component_style]
block_title = {fg="Red"}
border = {}
playback_track = { fg="Red", modifiers = ["Bold"] }
playback_artists = { fg="Red", modifiers = ["Bold"] }
playback_album = { fg="Red" }
playback_metadata = { fg = "BrightBlack" }
playback_progress_bar = { bg="Magenta", fg="Red" }
current_playing = { fg="Red", modifiers = ["Bold"] }
page_desc = { fg = "Cyan", modifiers = ["Bold"] }
table_header = { fg = "Blue" }
selection = { modifiers = ["Bold", "Reversed"] }`
after loading the theme name 'default' the spotify-player shows no color changes.
any help you can provide is greatly appreciated!
@aome510 commented on GitHub (Aug 26, 2023):
Ah thanks for pointing this out. Will update the document accordingly.Should use snake case when defining colors inpaletteas in the document. You can refer to https://github.com/aome510/spotify-player/blob/master/examples/theme.toml for more examples. For example,bright_bluevariable when defining palette will correspond toBrightBluewhen you definefgorbgin a component style.It's not possible to override the
defaulttheme configuration. You can name it something else and set thethemeconfig variable inapp.toml. Sorry for the confusion.@maglore9900 commented on GitHub (Aug 27, 2023):
Thank you! Ill give it a go. I should have known the "default" name was probably in use. Not sure what I was thinking.
Thanks again!
@maglore9900 commented on GitHub (Aug 27, 2023):
Works!
playback_progress_barcomponent style not working #636playback_progress_barcomponent style not working #1573