mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 01:15:55 +03:00
[GH-ISSUE #105] Allow Themes to feature Specified Background Image Files instead of Colors #42
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#42
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ForeignExchangeZtudent on GitHub (Jan 14, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/105
Honestly, everything about this is amazing.
The only thing I can request is being able to add background Images to themes to override background colors. It's the only thing really missing from this. (Either that or have an option to default to Terminal BG)
Thanks so much for working on this project!
@aome510 commented on GitHub (Jan 15, 2023):
hi @ForeignExchangeZtudent, thanks for the kind words. Hope u enjoy using
spotify-player.I don't think adding background image to override background color is possible. The app needs an allocated space to render an image. If that space is the whole application's window, the rendered image will hide the display text and other things.
I think what you want is a dim background image, which should be handled by your terminal. For example, in iterm2, you can set the terminal's background image by "Preferences > Profiles > Window > Background Image"
@ForeignExchangeZtudent commented on GitHub (Jan 15, 2023):
Ah, that's unfortunate. I usually prefer themeing with Transparency in mind around my Terminal windows and considering the ease of themeing and switching themes. It just feels a bit less on the customizable side to not allow for transparency color code either, at least if background-image is impossible.
Although now that I think about this was also an impossibility. Oh well.
@ForeignExchangeZtudent commented on GitHub (Jan 16, 2023):
Figured this one out, as well. No need for any additions! (Not that it was possible due to working in RGB Space (256colors))
Thanks again for this project and keeping minimalist spotify alive in the best way possible.
(Although Album Artwork freezes my Kitty, so I had to revert to non Image feature. No idea what may cause it. Not related to Spotify_player logs or backtrace and Kitty states its not frozen. Anyways, Album Artwork was just a luxury for me. So its' not a big deal.)