[PR #193] [MERGED] Add daemon support #1594

Closed
opened 2026-03-14 15:22:27 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/193
Author: @aome510
Created: 5/7/2023
Status: Merged
Merged: 5/8/2023
Merged by: @aome510

Base: masterHead: add-daemon-support


📝 Commits (9)

  • 46b0bb9 handle errors in the socket request handler instead of propagating the errors
  • d41cde7 add daemonize
  • 7abfb4b wip
  • 9a8e051 wip 2
  • c051b6f make new_streaming_connection non-async
  • c02f651 Merge branch 'master' into add-daemon-support
  • efcc525 add daemon feature
  • 45ef017 restructure the task spawn order
  • 3f99273 log when starting the app as a daemon

📊 Changes

7 files changed (+125 additions, -57 deletions)

View changed files

📝 Cargo.lock (+10 -0)
📝 spotify_player/Cargo.toml (+2 -0)
📝 spotify_player/src/cli/socket.rs (+15 -4)
📝 spotify_player/src/client/handlers.rs (+1 -4)
📝 spotify_player/src/client/mod.rs (+1 -1)
📝 spotify_player/src/main.rs (+87 -48)
📝 spotify_player/src/ui/mod.rs (+9 -0)

📄 Description

Resolves #135. Resolves #42.

Added support for daemonizing spotify_player.

Changes

  • added daemon feature
  • added -d/--daemon flag to run the application as a daemon
  • handled socket errors to avoid stopping the client loop when errors happen

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/193 **Author:** [@aome510](https://github.com/aome510) **Created:** 5/7/2023 **Status:** ✅ Merged **Merged:** 5/8/2023 **Merged by:** [@aome510](https://github.com/aome510) **Base:** `master` ← **Head:** `add-daemon-support` --- ### 📝 Commits (9) - [`46b0bb9`](https://github.com/aome510/spotify-player/commit/46b0bb9b82d9a458d79574d709aea34ffdde03c2) handle errors in the socket request handler instead of propagating the errors - [`d41cde7`](https://github.com/aome510/spotify-player/commit/d41cde73b5c190d8067f7d8aa9565cc1d10e7d67) add `daemonize` - [`7abfb4b`](https://github.com/aome510/spotify-player/commit/7abfb4bfec65cd086dd5a1fd6c5f75c6558d7917) wip - [`9a8e051`](https://github.com/aome510/spotify-player/commit/9a8e051414dc535e47733910dd532b4a9afe409c) wip 2 - [`c051b6f`](https://github.com/aome510/spotify-player/commit/c051b6f0ed2d1b7d4c37e406931c39a2d2298a03) make `new_streaming_connection` non-async - [`c02f651`](https://github.com/aome510/spotify-player/commit/c02f651fa47f7974a4cb44c89030ebeb77bebeaa) Merge branch 'master' into add-daemon-support - [`efcc525`](https://github.com/aome510/spotify-player/commit/efcc525b68682c2bb8784b543a1ff3030f02f53d) add `daemon` feature - [`45ef017`](https://github.com/aome510/spotify-player/commit/45ef0172fc3d3751467c5454cd37ff2b801d2091) restructure the task spawn order - [`3f99273`](https://github.com/aome510/spotify-player/commit/3f99273e8c84d0cafab3c13110d85d38718c1672) log when starting the app as a daemon ### 📊 Changes **7 files changed** (+125 additions, -57 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+10 -0) 📝 `spotify_player/Cargo.toml` (+2 -0) 📝 `spotify_player/src/cli/socket.rs` (+15 -4) 📝 `spotify_player/src/client/handlers.rs` (+1 -4) 📝 `spotify_player/src/client/mod.rs` (+1 -1) 📝 `spotify_player/src/main.rs` (+87 -48) 📝 `spotify_player/src/ui/mod.rs` (+9 -0) </details> ### 📄 Description Resolves #135. Resolves #42. Added support for daemonizing `spotify_player`. ## Changes - added `daemon` feature - added `-d`/`--daemon` flag to run the application as a daemon - handled socket errors to avoid stopping the client loop when errors happen --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-14 15:22:27 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/spotify-player#1594
No description provided.