[PR #385] Extended CI suite #1681

New issue

Open

opened 2026-03-14 15:27:12 +03:00 by kerem · 0 comments

kerem commented

2026-03-14 15:27:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aome510/spotify-player/pull/385
Author: @LucasFA
Created: 3/2/2024
Status: 🔄 Open

Base: master ← Head: ci-suite

📝 Commits (5)

1662348 Prepare for new CI
046d720 Add MSRV CI job
6a37d30 Add OS_SPECIFIC_FEATURES to rust-ci job
b605e17 Use spaces instead of commas as feature separator
72a4946 Factor out Linux packages

📊 Changes

4 files changed (+56 additions, -18 deletions)

View changed files

📝 .github/workflows/ci.yml (+40 -16)
📝 Cargo.toml (+9 -0)
📝 lyric_finder/Cargo.toml (+1 -0)
📝 spotify_player/Cargo.toml (+6 -2)

📄 Description

Took me a while to get around to it, but finally there's something to show for it.

Set a MSRV in the Cargo.toml and a new MSRV job
Check OS specific features, both in MSRV and general CI job
Cache ./target/ and creates a CI profile to reduce its cache usage, though Swatinem does a good job already
Reorders calls to cargo clippy and test to have the quickest at the beginning

I also took the liberty of reordering the features in the Cargo.toml file, in decreasing number of dependencies, mostly. We can drop that.
New (action) dependencies: taiki-e/install-action@v2 and Swatinem/rust-cache

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aome510/spotify-player/pull/385 **Author:** [@LucasFA](https://github.com/LucasFA) **Created:** 3/2/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `ci-suite` --- ### 📝 Commits (5) - [`1662348`](https://github.com/aome510/spotify-player/commit/1662348a237acae28e26d290dfcd9a13e02da94d) Prepare for new CI - [`046d720`](https://github.com/aome510/spotify-player/commit/046d720da2aaec7461d245a0d1288324aef1f385) Add MSRV CI job - [`6a37d30`](https://github.com/aome510/spotify-player/commit/6a37d308c7a719d578d4c0e7e22012368187b950) Add OS_SPECIFIC_FEATURES to rust-ci job - [`b605e17`](https://github.com/aome510/spotify-player/commit/b605e175f161a7cb921eef9de0f4eb2cc1c89aaf) Use spaces instead of commas as feature separator - [`72a4946`](https://github.com/aome510/spotify-player/commit/72a4946d2d9eed6a462411131f2126b3c0ba047f) Factor out Linux packages ### 📊 Changes **4 files changed** (+56 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci.yml` (+40 -16) 📝 `Cargo.toml` (+9 -0) 📝 `lyric_finder/Cargo.toml` (+1 -0) 📝 `spotify_player/Cargo.toml` (+6 -2) </details> ### 📄 Description Took me a while to get around to it, but finally there's something to show for it. - Set a MSRV in the Cargo.toml and a new MSRV job - Check OS specific features, both in MSRV and general CI job - Cache `./target/` and creates a CI profile to reduce its cache usage, though Swatinem does a good job already - Reorders calls to `cargo clippy` and `test` to have the quickest at the beginning I also took the liberty of reordering the features in the Cargo.toml file, in decreasing number of dependencies, mostly. We can drop that. New (action) dependencies: [taiki-e/install-action@v2](https://github.com/taiki-e/install-action) and [Swatinem/rust-cache](https://github.com/Swatinem/rust-cache) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>