mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #313] [feature]: add option for customize border color #165
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#165
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @diegoulloao on GitHub (Dec 6, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/313
Is your feature request related to a problem? Please describe.
Not a problem at all.
Describe the solution you'd like
I'd like to be able to pass an option for change the border color in hexadecimal format.
e.g:
spotify_player --border-color=#ff44ccDescribe alternatives you've considered
None. Open to new solutions.
Additional context
I'm using
spotify-playerinside neovim in an embed terminal for handy access.spotify-playeris using the neovim theme colors, but sometimes the border color is not the best looking, I'd like to be able to customize it passing the arg mentioned above. For sure this will help a lot of neovim users that we want to use this player embed.Here's a screenshot. I'm thinking in write an article teaching how to use
spotify-playerembed in neovim.Screenshot:

Here an embed terminal with customized border color (really nice looking):

Hope you can take this request 🙏🏻
@aome510 commented on GitHub (Dec 9, 2023):
spotify_playeralready supports configuringbordercomponent style as described in https://github.com/aome510/spotify-player/blob/master/docs/config.md#component-styles.The format for custom RGB color is quite awkward to use right now:
fg = { Rgb = { r = ..., g = ..., b = ... } }, which I'll update in a future release.For your use case, you can add a new theme in
theme.tomlconfig file based on thedefaulttheme and modify thebordercomponent style as follows (#ff44cc -> RGB(255, 68, 204))@aome510 commented on GitHub (Dec 9, 2023):
Update: for
v0.16.1onwards, you can use the hex string to configure component style's color