mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #542] Use display_name instead of the user's ID, if set. #313
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#313
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @dir on GitHub (Aug 10, 2024).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/542
Is your feature already implemented in the latest
master?No
Is your feature request related to a problem? Please describe.
spotify-player currently displays Spotify user IDs instead of
display_nameDescribe the solution you'd like
Use the
display_namefield from the Spotify API wherever user information is shown. Fall back to user ID ifdisplay_nameis null.Describe alternatives you've considered
Potentially configurations for
playlist_format, like{name} {creator_display_name}.Not the cleanest example, and the strings are different in different places, so mainly just spitballing there.
Additional context
Examples showing the chaotic UI where it renders my user ID only:
My Library

Playlist View

This change would make the app more intuitive and consistent with Spotify's official interfaces. As someone made the grave mistake of signing up with facebook way back when, all of my playlists, etc are marked with my user ID, and not my name.
P.S. I would love to implement this myself, but unfortunately I'm still quite new to Rust, and I was having a hard time wrapping my head around the codebase.
@dir commented on GitHub (Aug 11, 2024):
Hey all - apologies, I just spun up spotify-player and it looks as if my display name is now rendering.
I'm not sure what changed, maybe some fluke issue with my Spotify account? But, looks to be good now!
Sorry for the unnecessary issue, I'm really not sure what changed.
However, the "playlist_format" config option to be able to cherrypick specific values could be quite nice still!