[PR #87] [MERGED] Fix: Regression bug in submit_xml #86

Closed
opened 2026-02-27 23:18:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/87
Author: @mamullen13316
Created: 11/13/2024
Status: Merged
Merged: 11/13/2024
Merged by: @mamullen13316

Base: mainHead: submit_xml_fix


📝 Commits (2)

  • 28860c1 fix: correct payload for submit_xml
  • e615c8d version: update to v0.1.58

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/api_client.py (+2 -1)

📄 Description

  • Fix regression bug introduced by last PR in submit_xml. XML payload was incorrectly rendered by Jinja, causing API failure.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/87 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/13/2024 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `submit_xml_fix` --- ### 📝 Commits (2) - [`28860c1`](https://github.com/sophos/sophos-firewall-sdk/commit/28860c11bd0db4a2d85becfeca21e9b18e6371c2) fix: correct payload for submit_xml - [`e615c8d`](https://github.com/sophos/sophos-firewall-sdk/commit/e615c8d911e2907fd42f23e7fc5d01aa044081c9) version: update to v0.1.58 ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/api_client.py` (+2 -1) </details> ### 📄 Description - Fix regression bug introduced by last PR in `submit_xml`. XML payload was incorrectly rendered by Jinja, causing API failure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:18:59 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/sophos-firewall-sdk#86
No description provided.